From: Leonid Vasiliev via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Roman Khabibov <roman.habibov@tarantool.org>,
tarantool-patches@dev.tarantool.org
Cc: alexander.turenko@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/3] Export curl symbols, enable smtp and install headers
Date: Tue, 13 Apr 2021 16:14:28 +0300 [thread overview]
Message-ID: <8d5f9e4d-ccf7-61bb-d80f-b285342f1b04@tarantool.org> (raw)
In-Reply-To: <20210319141308.98726-1-roman.habibov@tarantool.org>
Hi! Thank you for the patchset.
Generally LGTM.
See several commits below:
1) Add changelogs.
2) Have you checked the patch on some deb and rpm based distributions?
On 3/19/21 5:13 PM, Roman Khabibov via Tarantool-patches wrote:
> The patchset is for 1.10 only.
>
> Issue: https://github.com/tarantool/smtp/issues/24
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/curl-smtp_1_10
>
> Roman Khabibov (3):
> build: export libCURL symbols
> build: enable smtp in libCURL
> build: install libCURL headers
>
> CMakeLists.txt | 17 ++++
> cmake/BuildLibCURL.cmake | 2 +-
> extra/curl_symbols | 81 ++++++++++++++++
> extra/mkexports | 14 ++-
> rpm/tarantool.spec | 9 ++
> src/CMakeLists.txt | 5 +-
> test/box-tap/curl-build.test.lua | 160 +++++++++++++++++++++++++++++++
> 7 files changed, 282 insertions(+), 6 deletions(-)
> create mode 100755 extra/curl_symbols
> create mode 100755 test/box-tap/curl-build.test.lua
>
next prev parent reply other threads:[~2021-04-13 13:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 14:13 Roman Khabibov via Tarantool-patches
2021-03-19 14:13 ` [Tarantool-patches] [PATCH 1/3] build: export libCURL symbols Roman Khabibov via Tarantool-patches
2021-03-31 23:56 ` Alexander Turenko via Tarantool-patches
2021-04-09 19:54 ` Roman Khabibov via Tarantool-patches
2021-04-01 0:01 ` Alexander Turenko via Tarantool-patches
2021-03-19 14:13 ` [Tarantool-patches] [PATCH 2/3] build: enable smtp in libCURL Roman Khabibov via Tarantool-patches
2021-04-01 0:52 ` Alexander Turenko via Tarantool-patches
2021-04-09 19:54 ` Roman Khabibov via Tarantool-patches
2021-03-19 14:13 ` [Tarantool-patches] [PATCH 3/3] build: install libCURL headers Roman Khabibov via Tarantool-patches
2021-04-01 0:10 ` Alexander Turenko via Tarantool-patches
2021-04-09 19:54 ` Roman Khabibov via Tarantool-patches
2021-04-13 13:14 ` Leonid Vasiliev via Tarantool-patches [this message]
2021-04-14 17:52 ` [Tarantool-patches] [PATCH 0/3] Export curl symbols, enable smtp and install headers Roman Khabibov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d5f9e4d-ccf7-61bb-d80f-b285342f1b04@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=lvasiliev@tarantool.org \
--cc=roman.habibov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] Export curl symbols, enable smtp and install headers' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox