Re: [Tarantool-patches] [PATCH luajit 1/3] MIPS64: Fix xpcall() error case.

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1523 bytes --]

Hi, Sergey,

thanks for long-awaited review!

On 2/11/26 10:17, Sergey Kaplun via Tarantool-patches wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, with minor nits.
>
> On 10.12.25, Sergey Bronnikov wrote:
>> From: Mike Pall <mike>
>>
>> Thanks to François Perrad and Stefan Pejic.
>>
>> (cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)
>>
>> The patch fixes `xpcall()` segfaults on MIPS64 commit. The similar
> Typo: s/commit/architecture/

Fixed.


>> patch for ARM64 has been backported previously, see the commit
> Minor: s/backported previously/backported (with the test) previously/

Fixed as well.

Updated commit message:

commit b5a84d2ba13df4d48c8ba46ee41a93f17dc00782 (HEAD)
Author: Mike Pall <mike>
Date:   Sat Nov 18 12:25:35 2017 +0100

     MIPS64: Fix xpcall() error case.

     Thanks to François Perrad and Stefan Pejic.

     (cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)

     The patch fixes `xpcall()` segfaults on MIPS64 architecture.
     The similar patch for ARM64 has been backported (with the test)
     previously, see the commit af889e4608e6eca495dd85e6161d8bcd7d3628e6
     ("ARM64: Fix xpcall() error case (really).").

     Sergey Bronnikov:
     * added the description

     Part of tarantool/tarantool#12134

>
>> af889e4608e6eca495dd85e6161d8bcd7d3628e6 ("ARM64: Fix xpcall()
>> error case (really).").
>>
>> Sergey Bronnikov:
>> * added the description
>>
>> Part of tarantool/tarantool#12134
>> ---
> <snipped>
>

[-- Attachment #2: Type: text/html, Size: 2919 bytes --]