From: sergepetrenko <sergepetrenko@tarantool.org>
To: v.shpilevoy@tarantool.org, georgy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 1/5] box: update comment describing join protocol
Date: Wed, 25 Dec 2019 15:46:58 +0300 [thread overview]
Message-ID: <8c6525b4c4c3331a4b92b56211b5cb72321e2922.1577277455.git.sergepetrenko@tarantool.org> (raw)
In-Reply-To: <cover.1577277455.git.sergepetrenko@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
The comment states that relay sends the latest snapshot to replica
during initial join, however, this was changed in commit
6332aca655ae7f95d391bdc0109e79915f6e6ad0 (relay: join new replicas off
read view).
Now relay sends rows from the read view created at the moment of join.
Update the comment to match.
Follow-up #1271
---
src/box/box.cc | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/box/box.cc b/src/box/box.cc
index b119c927b..22ac8bda1 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -1391,13 +1391,14 @@ box_process_join(struct ev_io *io, struct xrow_header *header)
* => JOIN { INSTANCE_UUID: replica_uuid }
* <= OK { VCLOCK: start_vclock }
* Replica has enough permissions and master is ready for JOIN.
- * - start_vclock - vclock of the latest master's checkpoint.
+ * - start_vclock - master's vclock at the time of join.
*
* <= INSERT
* ...
* Initial data: a stream of engine-specifc rows, e.g. snapshot
- * rows for memtx or dirty cursor data for Vinyl. Engine can
- * use REPLICA_ID, LSN and other fields for internal purposes.
+ * rows for memtx or dirty cursor data for Vinyl fed from a
+ * read-view. Engine can use REPLICA_ID, LSN and other fields
+ * for internal purposes.
* ...
* <= INSERT
* <= OK { VCLOCK: stop_vclock } - end of initial JOIN stage.
--
2.20.1 (Apple Git-117)
next prev parent reply other threads:[~2019-12-25 12:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-25 12:46 [Tarantool-patches] [PATCH v2 0/5] introduce anonymous replicas sergepetrenko
2019-12-25 12:46 ` sergepetrenko [this message]
2019-12-25 12:46 ` [Tarantool-patches] [PATCH v2 2/5] replication: do not decode replicaset uuid when processing a subscribe sergepetrenko
2019-12-25 12:47 ` [Tarantool-patches] [PATCH v2 3/5] applier: split join processing into two stages sergepetrenko
2019-12-25 12:47 ` [Tarantool-patches] [PATCH v2 4/5] vclock: ignore 0th component in comparisons sergepetrenko
2019-12-25 16:00 ` Vladislav Shpilevoy
2019-12-27 18:42 ` Vladislav Shpilevoy
2019-12-28 11:21 ` Sergey Petrenko
2019-12-25 12:47 ` [Tarantool-patches] [PATCH v2 5/5] replication: introduce anonymous replica sergepetrenko
2019-12-25 18:22 ` Vladislav Shpilevoy
2019-12-27 15:27 ` Sergey Petrenko
2019-12-27 18:42 ` Vladislav Shpilevoy
2019-12-28 11:48 ` Sergey Petrenko
2019-12-28 12:15 ` Vladislav Shpilevoy
2019-12-30 5:12 ` [Tarantool-patches] [PATCH v2 0/5] introduce anonymous replicas Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c6525b4c4c3331a4b92b56211b5cb72321e2922.1577277455.git.sergepetrenko@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=georgy@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/5] box: update comment describing join protocol' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox