Tarantool development patches archive
 help / color / mirror / Atom feed
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
	Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
	Alexander Turenko <alexander.turenko@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] lua: fix strange behaviour of tonumber64
Date: Tue, 17 Jul 2018 15:03:53 +0300	[thread overview]
Message-ID: <8bda0436-9681-5662-9f51-927cbf26fbae@tarantool.org> (raw)
In-Reply-To: <20180717112746.mh2cqq22acw4mtsu@tkn_work_nb>

>>> +-- gh-3466: Strange behaviour of tonumber64 function
>>> +--
>>> +tostring(tonumber64('18446744073709551615')) == '18446744073709551615ULL'
>>> +tonumber64('18446744073709551616') == nil
>> 2. Where is a test for another corner case? I mean INT64_MAX.
Actually, the max value is not INT64_MAX; but UINT64_MAX that is tested above.
But I don't mind to add INT64_MAX test.
+tostring(tonumber64('9223372036854775807')) == '9223372036854775807ULL'

> I also propose to test zero.
+tostring(tonumber64('0')) == '0'

> 1. Please, add a comment about the things we have discussed as Alexander asked
> in the previous message.
+                               /*
+                                * To test overflow, consider
+                                *  result > -INT64_MIN;
+                                *  result - 1 > -INT64_MIN - 1;
+                                * Assumption:
+                                *  INT64_MAX == -(INT64_MIN + 1);
+                                * Finally,
+                                *  result - 1 > INT64_MAX;
+                                */

  reply	other threads:[~2018-07-17 12:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-13 11:21 [tarantool-patches] " Kirill Shcherbatov
2018-07-16 10:23 ` [tarantool-patches] " Vladislav Shpilevoy
2018-07-16 12:49   ` Alexander Turenko
2018-07-16 13:15     ` Vladislav Shpilevoy
2018-07-16 13:42       ` Alexander Turenko
2018-07-16 13:55         ` Vladislav Shpilevoy
2018-07-16 14:09           ` Alexander Turenko
2018-07-16 16:52             ` Kirill Shcherbatov
2018-07-17  9:35               ` Vladislav Shpilevoy
2018-07-17 11:27                 ` Alexander Turenko
2018-07-17 12:03                   ` Kirill Shcherbatov [this message]
2018-07-17 21:48                     ` Vladislav Shpilevoy
2018-07-19 10:46 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8bda0436-9681-5662-9f51-927cbf26fbae@tarantool.org \
    --to=kshcherbatov@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='[tarantool-patches] Re: [PATCH v1 1/1] lua: fix strange behaviour of tonumber64' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox