* [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer
@ 2020-02-13 8:06 Sergey Kaplun
2020-02-13 8:16 ` Leonid Vasiliev
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Sergey Kaplun @ 2020-02-13 8:06 UTC (permalink / raw)
To: tarantool-patches; +Cc: Vladislav Shpilevoy
We already have 12Kb thread-safe static buffer
in `lib/small/small/static.h`, that can be used instead of 16Kb
bss buffer in `src/lib/core/backtrace.cc` for backtrace payload.
Closes #4650
---
branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff
issue: https://github.com/tarantool/tarantool/issues/4650
src/lib/core/backtrace.cc | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc
index 77f77b05c..b5531a596 100644
--- a/src/lib/core/backtrace.cc
+++ b/src/lib/core/backtrace.cc
@@ -47,16 +47,15 @@
#include <libunwind.h>
#include "small/region.h"
+#include "small/static.h"
/*
- * We use a global static buffer because it is too late to do any
+ * We use a static buffer interface because it is too late to do any
* allocation when we are printing backtrace and fiber stack is
* small.
*/
#define BACKTRACE_NAME_MAX 200
-static char backtrace_buf[4096 * 4];
-
static __thread struct region cache_region;
static __thread struct mh_i64ptr_t *proc_cache = NULL;
@@ -140,8 +139,9 @@ backtrace()
unw_getcontext(&unw_context);
unw_cursor_t unw_cur;
unw_init_local(&unw_cur, &unw_context);
+ char *backtrace_buf = (char *)static_alloc(SMALL_STATIC_SIZE);
char *p = backtrace_buf;
- char *end = p + sizeof(backtrace_buf) - 1;
+ char *end = p + SMALL_STATIC_SIZE - 1;
int unw_status;
*p = '\0';
while ((unw_status = unw_step(&unw_cur)) > 0) {
--
2.24.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer
2020-02-13 8:06 [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer Sergey Kaplun
@ 2020-02-13 8:16 ` Leonid Vasiliev
2020-02-13 21:54 ` Vladislav Shpilevoy
2020-02-14 8:59 ` Kirill Yukhin
2 siblings, 0 replies; 4+ messages in thread
From: Leonid Vasiliev @ 2020-02-13 8:16 UTC (permalink / raw)
To: Sergey Kaplun, tarantool-patches; +Cc: Vladislav Shpilevoy
LGTM
On 2/13/20 11:06 AM, Sergey Kaplun wrote:
> We already have 12Kb thread-safe static buffer
> in `lib/small/small/static.h`, that can be used instead of 16Kb
> bss buffer in `src/lib/core/backtrace.cc` for backtrace payload.
>
> Closes #4650
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff
> issue: https://github.com/tarantool/tarantool/issues/4650
>
> src/lib/core/backtrace.cc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc
> index 77f77b05c..b5531a596 100644
> --- a/src/lib/core/backtrace.cc
> +++ b/src/lib/core/backtrace.cc
> @@ -47,16 +47,15 @@
> #include <libunwind.h>
>
> #include "small/region.h"
> +#include "small/static.h"
> /*
> - * We use a global static buffer because it is too late to do any
> + * We use a static buffer interface because it is too late to do any
> * allocation when we are printing backtrace and fiber stack is
> * small.
> */
>
> #define BACKTRACE_NAME_MAX 200
>
> -static char backtrace_buf[4096 * 4];
> -
> static __thread struct region cache_region;
> static __thread struct mh_i64ptr_t *proc_cache = NULL;
>
> @@ -140,8 +139,9 @@ backtrace()
> unw_getcontext(&unw_context);
> unw_cursor_t unw_cur;
> unw_init_local(&unw_cur, &unw_context);
> + char *backtrace_buf = (char *)static_alloc(SMALL_STATIC_SIZE);
> char *p = backtrace_buf;
> - char *end = p + sizeof(backtrace_buf) - 1;
> + char *end = p + SMALL_STATIC_SIZE - 1;
> int unw_status;
> *p = '\0';
> while ((unw_status = unw_step(&unw_cur)) > 0) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer
2020-02-13 8:06 [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer Sergey Kaplun
2020-02-13 8:16 ` Leonid Vasiliev
@ 2020-02-13 21:54 ` Vladislav Shpilevoy
2020-02-14 8:59 ` Kirill Yukhin
2 siblings, 0 replies; 4+ messages in thread
From: Vladislav Shpilevoy @ 2020-02-13 21:54 UTC (permalink / raw)
To: Sergey Kaplun, tarantool-patches
Hi! Thanks for the patch! LGTM.
On 13/02/2020 09:06, Sergey Kaplun wrote:
> We already have 12Kb thread-safe static buffer
> in `lib/small/small/static.h`, that can be used instead of 16Kb
> bss buffer in `src/lib/core/backtrace.cc` for backtrace payload.
>
> Closes #4650
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff
> issue: https://github.com/tarantool/tarantool/issues/4650
>
> src/lib/core/backtrace.cc | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer
2020-02-13 8:06 [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer Sergey Kaplun
2020-02-13 8:16 ` Leonid Vasiliev
2020-02-13 21:54 ` Vladislav Shpilevoy
@ 2020-02-14 8:59 ` Kirill Yukhin
2 siblings, 0 replies; 4+ messages in thread
From: Kirill Yukhin @ 2020-02-14 8:59 UTC (permalink / raw)
To: Sergey Kaplun; +Cc: tarantool-patches, Vladislav Shpilevoy
Hello,
On 13 фев 11:06, Sergey Kaplun wrote:
> We already have 12Kb thread-safe static buffer
> in `lib/small/small/static.h`, that can be used instead of 16Kb
> bss buffer in `src/lib/core/backtrace.cc` for backtrace payload.
>
> Closes #4650
> ---
>
> branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff
> issue: https://github.com/tarantool/tarantool/issues/4650
I've checked your patch into master.
--
Regards, Kirill Yukhin
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-02-14 8:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-13 8:06 [Tarantool-patches] [PATCH v3] refactoring: drop excess 16Kb bss buffer Sergey Kaplun
2020-02-13 8:16 ` Leonid Vasiliev
2020-02-13 21:54 ` Vladislav Shpilevoy
2020-02-14 8:59 ` Kirill Yukhin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox