From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
Kostya Osipov <kostja@tarantool.org>,
Nikita Pettik <korablev@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v2 08/12] sql: rfc for SQL and Lua functions
Date: Thu, 11 Jul 2019 10:40:00 +0300 [thread overview]
Message-ID: <8bc802de-06cd-0ec4-1441-fe55343de6f2@tarantool.org> (raw)
In-Reply-To: <20190710191811.GJ5619@atlas>
>> The spec generally looks good to me, but I don't see how you
>> addressed the case sensitivity issue. Please add name_ucase field
>> to the _func definition, and add a unique index over it, to
>> prevent duplicates with a differently cased name.
>
> Sorry, forget this. Hit "send" too hastily. I noticed that you
> changed the unique index collation on "name" to case insensitive.
> Please mention this in the spec, I missed that at first. After
> that the spec is OK to push.
There was a string:
"We must forbid such names for `box.schema.func.create` endpoint to prevent a mess in SQL code.
To solve this problem, we may set `collation = 'unicode_ci'` for ``_func.name`` field and put all built-ins in bootstrap image."
in RFC already.
next prev parent reply other threads:[~2019-07-11 7:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-10 11:00 [tarantool-patches] [PATCH v2 00/12] sql: uniform SQL and Lua functions subsystem Kirill Shcherbatov
2019-07-10 11:00 ` [tarantool-patches] [PATCH v2 01/12] sql: get rid of SOUNDEX, MATCH Kirill Shcherbatov
2019-07-10 18:45 ` [tarantool-patches] " Konstantin Osipov
2019-07-12 8:44 ` Kirill Yukhin
2019-07-10 11:00 ` [tarantool-patches] [PATCH v2 10/12] sql: refactor builtins signatures with port Kirill Shcherbatov
2019-07-10 18:47 ` [tarantool-patches] " Konstantin Osipov
2019-07-11 7:33 ` Kirill Shcherbatov
2019-07-10 11:00 ` [tarantool-patches] [PATCH v2 11/12] box: use own vtab per each function object Kirill Shcherbatov
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 12/12] sql: use schema's func hash instead of FuncDef hash Kirill Shcherbatov
2019-07-10 20:22 ` [tarantool-patches] " Konstantin Osipov
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 02/12] sql: get rid of LIKELY, UNLIKELY and LIKEHOOD Kirill Shcherbatov
2019-07-10 19:02 ` [tarantool-patches] " Konstantin Osipov
2019-07-11 7:38 ` Kirill Shcherbatov
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 03/12] sql: put analyze helpers to FuncDef cache Kirill Shcherbatov
2019-07-10 19:04 ` [tarantool-patches] " Konstantin Osipov
2019-07-12 8:47 ` Kirill Yukhin
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 04/12] sql: rework LIKE case-insensitive mode Kirill Shcherbatov
2019-07-10 19:09 ` [tarantool-patches] " Konstantin Osipov
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 05/12] sql: replace bool is_derived_coll marker with flag Kirill Shcherbatov
2019-07-10 19:10 ` [tarantool-patches] " Konstantin Osipov
2019-07-12 8:48 ` Kirill Yukhin
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 06/12] sql: remove SQL_PreferBuiltin flag Kirill Shcherbatov
2019-07-10 19:11 ` [tarantool-patches] " Konstantin Osipov
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 07/12] sql: move LIKE UConverter object to collation library Kirill Shcherbatov
2019-07-12 8:49 ` [tarantool-patches] " Kirill Yukhin
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 08/12] sql: rfc for SQL and Lua functions Kirill Shcherbatov
2019-07-10 19:17 ` [tarantool-patches] " Konstantin Osipov
2019-07-10 19:18 ` Konstantin Osipov
2019-07-11 7:40 ` Kirill Shcherbatov [this message]
2019-07-11 13:59 ` Kirill Yukhin
2019-07-10 11:01 ` [tarantool-patches] [PATCH v2 09/12] box: introduce Lua persistent functions Kirill Shcherbatov
2019-07-10 19:26 ` [tarantool-patches] " Konstantin Osipov
2019-07-12 21:49 ` Konstantin Osipov
2019-07-13 13:55 ` Kirill Yukhin
2019-07-13 14:17 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bc802de-06cd-0ec4-1441-fe55343de6f2@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kostja@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v2 08/12] sql: rfc for SQL and Lua functions' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox