Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
	tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate replication_synchro_quorum dynamically
Date: Tue, 22 Dec 2020 14:49:06 +0100	[thread overview]
Message-ID: <8b570db3-858d-4475-1f9f-7e5c84321129@tarantool.org> (raw)
In-Reply-To: <20201222111408.48368-1-gorcunov@gmail.com>

Hi! Thanks for the patchset!

Looks good, except that the test is still flaky. I run it
with the same command as earlier, and got this:

[015] Test failed! Result content mismatch:
[015] --- replication/gh-5446-qsync-eval-quorum.result	Tue Dec 22 14:45:06 2020
[015] +++ var/rejects/replication/gh-5446-qsync-eval-quorum.reject	Tue Dec 22 14:47:31 2020
[015] @@ -50,7 +50,6 @@
[015]   | ...
[015]  test_run:wait_log('default', match, nil, 5)
[015]   | ---
[015] - | - set 'replication_synchro_quorum' configuration option to "N\/2+1
[015]   | ...
[015]  
[015]  -- Create a sync space we will operate on
[015] 

The command looks like this:

	python test-run.py gh-5446- gh-5446- gh-5446- gh-5446- gh-5446- gh-5446 ... <many many more>

Test-run says I run this test 258 times in the command above.

  parent reply	other threads:[~2020-12-22 13:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-22 11:14 Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 1/5] cfg: add cfg_isnumber helper Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 2/5] cfg: rework box_check_replication_synchro_quorum Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 3/5] cfg: support symbolic evaluation of replication_synchro_quorum Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 4/5] cfg: more precise check for replication_synchro_quorum value Cyrill Gorcunov
2020-12-22 11:14 ` [Tarantool-patches] [PATCH v6 5/5] test: add replication/gh-5446-qsync-eval-quorum.test.lua Cyrill Gorcunov
2020-12-22 13:49 ` Vladislav Shpilevoy [this message]
2020-12-22 13:53   ` [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate replication_synchro_quorum dynamically Cyrill Gorcunov
2020-12-22 14:32   ` Cyrill Gorcunov
2020-12-22 17:13   ` Cyrill Gorcunov
2020-12-23 14:14     ` Vladislav Shpilevoy
2020-12-23 15:54       ` Cyrill Gorcunov
2020-12-23 17:52 ` Vladislav Shpilevoy
2020-12-24 13:55   ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8b570db3-858d-4475-1f9f-7e5c84321129@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate replication_synchro_quorum dynamically' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox