From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 70DFF4765E0
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 22 Dec 2020 16:49:08 +0300 (MSK)
References: <20201222111408.48368-1-gorcunov@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <8b570db3-858d-4475-1f9f-7e5c84321129@tarantool.org>
Date: Tue, 22 Dec 2020 14:49:06 +0100
MIME-Version: 1.0
In-Reply-To: <20201222111408.48368-1-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v6 0/5] qsync: evaluate
 replication_synchro_quorum dynamically
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for the patchset!

Looks good, except that the test is still flaky. I run it
with the same command as earlier, and got this:

[015] Test failed! Result content mismatch:
[015] --- replication/gh-5446-qsync-eval-quorum.result	Tue Dec 22 14:45:06 2020
[015] +++ var/rejects/replication/gh-5446-qsync-eval-quorum.reject	Tue Dec 22 14:47:31 2020
[015] @@ -50,7 +50,6 @@
[015]   | ...
[015]  test_run:wait_log('default', match, nil, 5)
[015]   | ---
[015] - | - set 'replication_synchro_quorum' configuration option to "N\/2+1
[015]   | ...
[015]  
[015]  -- Create a sync space we will operate on
[015] 

The command looks like this:

	python test-run.py gh-5446- gh-5446- gh-5446- gh-5446- gh-5446- gh-5446 ... <many many more>

Test-run says I run this test 258 times in the command above.