From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [RFC PATCH 09/12] box: connect to remote peers before starting local recovery Date: Wed, 6 Jun 2018 20:45:09 +0300 [thread overview] Message-ID: <8ab6c04781f60db37b4e3848605b631ff1c1b45b.1528305232.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1528305232.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1528305232.git.vdavydov.dev@gmail.com> box_sync_replication() can now be called before recovery, right after box_listen(). This is a step toward detecting if the instance fell too much behind its peers in the cluster and so needs to be rebootstrapped. Needed for #461 --- src/box/box.cc | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/box/box.cc b/src/box/box.cc index fce5ebb1..2ff9fb5f 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -1852,8 +1852,10 @@ box_cfg_xc(void) */ recovery_end_vclock(recovery, &replicaset.vclock); - if (wal_dir_lock >= 0) + if (wal_dir_lock >= 0) { box_listen(); + box_sync_replication(replication_connect_timeout, false); + } /* * recovery->vclock is needed by Vinyl to filter @@ -1911,6 +1913,7 @@ box_cfg_xc(void) */ vclock_copy(&replicaset.vclock, &recovery->vclock); box_listen(); + box_sync_replication(replication_connect_timeout, false); } recovery_finalize(recovery); engine_end_recovery_xc(); @@ -1925,11 +1928,6 @@ box_cfg_xc(void) /* Clear the pointer to journal before it goes out of scope */ journal_set(NULL); - - title("orphan"); - - /* Wait for the cluster to start up */ - box_sync_replication(replication_connect_timeout, false); } else { if (!tt_uuid_is_nil(&instance_uuid)) INSTANCE_UUID = instance_uuid; @@ -1941,8 +1939,6 @@ box_cfg_xc(void) */ box_listen(); - title("orphan"); - /* * Wait for the cluster to start up. * @@ -1978,6 +1974,8 @@ box_cfg_xc(void) rmean_cleanup(rmean_box); + title("orphan"); + /* * If this instance is a leader of a newly bootstrapped * cluster, it is uptodate by definition so leave the -- 2.11.0
next prev parent reply other threads:[~2018-06-06 17:45 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-06 17:45 [RFC PATCH 00/12] Replica rejoin Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 01/12] recovery: drop unused recovery_exit Vladimir Davydov 2018-06-08 4:13 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 02/12] recovery: constify vclock argument Vladimir Davydov 2018-06-08 4:14 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 03/12] applier: remove extra new line in log message printed on connect Vladimir Davydov 2018-06-08 4:15 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 04/12] xrow: add helper function for encoding vclock Vladimir Davydov 2018-06-08 4:16 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 05/12] box: retrieve instance uuid before starting local recovery Vladimir Davydov 2018-06-08 4:22 ` Konstantin Osipov 2018-06-06 17:45 ` [RFC PATCH 06/12] box: refactor hot standby recovery Vladimir Davydov 2018-06-08 4:40 ` Konstantin Osipov 2018-06-08 6:43 ` Vladimir Davydov 2018-06-08 13:15 ` Konstantin Osipov 2018-06-08 13:30 ` Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 07/12] box: retrieve end vclock before starting local recovery Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 08/12] box: open the port " Vladimir Davydov 2018-06-06 17:45 ` Vladimir Davydov [this message] 2018-06-06 17:45 ` [RFC PATCH 10/12] box: factor out local recovery function Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 11/12] applier: inquire oldest vclock on connect Vladimir Davydov 2018-06-06 17:45 ` [RFC PATCH 12/12] replication: rebootstrap instance on startup if it fell behind Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8ab6c04781f60db37b4e3848605b631ff1c1b45b.1528305232.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [RFC PATCH 09/12] box: connect to remote peers before starting local recovery' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox