From: Sergey Bronnikov <sergeyb@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>,
Alexander Turenko <alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module
Date: Wed, 25 Nov 2020 12:27:57 +0300 [thread overview]
Message-ID: <8aa301dc-a0b4-e496-b03e-3d7cbe2feac9@tarantool.org> (raw)
In-Reply-To: <CAM5jBj4kj8sOysc_xHVy_+1YGEcL8g1-U07POUE4rRiV=o7h4w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
Hmm, overlooked this patch. No, this is more than enough.
On 19.11.2020 23:52, Cyrill Gorcunov wrote:
> Wait, Sergey, I dropped it already or you mean something else?
> (Sorry for toppost)
>
> @@ -29,7 +29,6 @@ include_files = {
> exclude_files = {
> "build/**/*.lua",
> -- Third-party source code.
> - "src/box/lua/serpent.lua",
> "test-run/**/*.lua",
> "test/**/*.lua",
> "third_party/**/*.lua",
>
> On Thu, Nov 19, 2020 at 3:05 PM Cyrill Gorcunov <gorcunov@gmail.com
> <mailto:gorcunov@gmail.com>> wrote:
>
> On Thu, Nov 19, 2020 at 02:55:14PM +0300, Sergey Bronnikov wrote:
> > Hi, Cyrill!
> >
> > thanks for the patch! I propose to get rid of exclude for serpent in
> > .luacheckrc too.
>
> Yeah, need to drop it from there as well, I'll update, thanks!
>
[-- Attachment #2: Type: text/html, Size: 1972 bytes --]
next prev parent reply other threads:[~2020-11-25 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 14:56 Cyrill Gorcunov
2020-11-19 11:55 ` Sergey Bronnikov
2020-11-19 12:05 ` Cyrill Gorcunov
2020-11-19 20:52 ` Cyrill Gorcunov
2020-11-25 9:27 ` Sergey Bronnikov [this message]
2020-12-01 9:29 ` Alexander V. Tikhonov
2020-12-01 12:20 ` Alexander Turenko
2020-12-01 12:22 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8aa301dc-a0b4-e496-b03e-3d7cbe2feac9@tarantool.org \
--to=sergeyb@tarantool.org \
--cc=alexander.turenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] console: drop unused serpent module' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox