From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 28D6F469710 for ; Wed, 25 Nov 2020 12:27:58 +0300 (MSK) References: <20201113145648.268768-1-gorcunov@gmail.com> <20201119120511.GR2021@grain> From: Sergey Bronnikov Message-ID: <8aa301dc-a0b4-e496-b03e-3d7cbe2feac9@tarantool.org> Date: Wed, 25 Nov 2020 12:27:57 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/alternative; boundary="------------352C02892A5EEA3872EE8F8A" Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH] console: drop unused serpent module List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov Cc: tml , Alexander Turenko This is a multi-part message in MIME format. --------------352C02892A5EEA3872EE8F8A Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Hmm, overlooked this patch. No, this is more than enough. On 19.11.2020 23:52, Cyrill Gorcunov wrote: > Wait, Sergey, I dropped it already or you mean something else? > (Sorry for toppost) > > @@ -29,7 +29,6 @@ include_files = { >  exclude_files = { >      "build/**/*.lua", >      -- Third-party source code. > -    "src/box/lua/serpent.lua", >      "test-run/**/*.lua", >      "test/**/*.lua", >      "third_party/**/*.lua", > > On Thu, Nov 19, 2020 at 3:05 PM Cyrill Gorcunov > wrote: > > On Thu, Nov 19, 2020 at 02:55:14PM +0300, Sergey Bronnikov wrote: > > Hi, Cyrill! > > > > thanks for the patch! I propose to get rid of exclude for serpent in > > .luacheckrc too. > > Yeah, need to drop it from there as well, I'll update, thanks! > --------------352C02892A5EEA3872EE8F8A Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

Hmm, overlooked this patch. No, this is more than enough.

On 19.11.2020 23:52, Cyrill Gorcunov wrote:
Wait, Sergey, I dropped it already or you mean something else?
(Sorry for toppost)

@@ -29,7 +29,6 @@ include_files = {
 exclude_files = {
     "build/**/*.lua",
     -- Third-party source code.
-    "src/box/lua/serpent.lua",
     "test-run/**/*.lua",
     "test/**/*.lua",
     "third_party/**/*.lua",

On Thu, Nov 19, 2020 at 3:05 PM Cyrill Gorcunov <gorcunov@gmail.com> wrote:
On Thu, Nov 19, 2020 at 02:55:14PM +0300, Sergey Bronnikov wrote:
> Hi, Cyrill!
>
> thanks for the patch! I propose to get rid of exclude for serpent in
> .luacheckrc too.

Yeah, need to drop it from there as well, I'll update, thanks!
--------------352C02892A5EEA3872EE8F8A--