From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Imeev Mergen <imeevma@tarantool.org> Subject: [tarantool-patches] Re: [PATCH v2 1/3] sql: remove unnecessary AUTOINCREMENT ID generation Date: Mon, 8 Jul 2019 21:54:11 +0300 [thread overview] Message-ID: <8FEB50DF-9030-41DB-B113-FDDE6EF3B1C1@tarantool.org> (raw) In-Reply-To: <96975db4f246bc09a3801dd247f5ab65d7709a6f.1562239051.git.imeevma@gmail.com> > On 4 Jul 2019, at 14:42, imeevma@tarantool.org wrote: > > Currently, if we perform something like > CREATE TABLE t (i INT PRIMARY KEY AUTOINCREMENT); > INSERT INTO t(a) VALUES (NULL); > > we generate a new identifier in a special way. Describe this “special” way. > src/box/sql/insert.c | 5 +---- > test/sql/gh-2981-check-autoinc.result | 32 ++++++++++++++++++++++++++++++++ > test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++++++- > 3 files changed, 43 insertions(+), 5 deletions(-) > > diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c > index b353148..d2b4e17 100644 > --- a/src/box/sql/insert.c > +++ b/src/box/sql/insert.c > @@ -628,10 +628,7 @@ sqlInsert(Parse * pParse, /* Parser context */ > if (j < 0 || nColumn == 0 > || (pColumn && j >= pColumn->nId)) { > if (i == (int) autoinc_fieldno) { > - sqlVdbeAddOp2(v, > - OP_NextAutoincValue, > - space->def->id, > - iRegStore); Why didn’t you delete OP_NextAutioncValue? > + sqlVdbeAddOp2(v, OP_Null, 0, iRegStore); > continue; > } > struct Expr *dflt = NULL; > > diff --git a/test/sql/gh-2981-check-autoinc.test.lua b/test/sql/gh-2981-check-autoinc.test.lua > index 0eb8f73..ac5624e 100644 > --- a/test/sql/gh-2981-check-autoinc.test.lua > +++ b/test/sql/gh-2981-check-autoinc.test.lua > @@ -7,6 +7,8 @@ box.cfg{} > box.execute("CREATE TABLE t1 (s1 INTEGER PRIMARY KEY AUTOINCREMENT, s2 INTEGER, CHECK (s1 <> 19));"); > box.execute("CREATE TABLE t2 (s1 INTEGER PRIMARY KEY AUTOINCREMENT, s2 INTEGER, CHECK (s1 <> 19 AND s1 <> 25));"); > box.execute("CREATE TABLE t3 (s1 INTEGER PRIMARY KEY AUTOINCREMENT, s2 INTEGER, CHECK (s1 < 10));”); > +box.execute("CREATE TABLE t4 (s1 INTEGER PRIMARY KEY AUTOINCREMENT, s2 INTEGER, CHECK (s1 < 10));"); > +box.execute("CREATE TABLE t5 (s1 INTEGER PRIMARY KEY AUTOINCREMENT, s2 INTEGER, CHECK (s1 <> 19));”); Add explanation to these tests.. What do they verify? I build master branch and they are passed as well. > box.execute("insert into t1 values (18, null);") > box.execute("insert into t1(s2) values (null);") > @@ -19,7 +21,14 @@ box.execute("insert into t2(s2) values (null);") > box.execute("insert into t3 values (9, null)") > box.execute("insert into t3(s2) values (null)") > > +box.execute("insert into t4 values (9, null)") > +box.execute("insert into t4 values (null, null)") > + > +box.execute("INSERT INTO t5 VALUES (18, NULL);") > +box.execute("INSERT INTO t5 SELECT NULL, NULL FROM t5;") > +
next prev parent reply other threads:[~2019-07-08 18:54 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-04 11:42 [tarantool-patches] [PATCH v2 0/3] sql: do not show IDs generated by trigger imeevma 2019-07-04 11:42 ` [tarantool-patches] [PATCH v2 1/3] sql: remove unnecessary AUTOINCREMENT ID generation imeevma 2019-07-08 18:54 ` n.pettik [this message] 2019-07-04 11:42 ` [tarantool-patches] [PATCH v2 2/3] sql: do not show IDs generated by trigger imeevma 2019-07-08 18:54 ` [tarantool-patches] " n.pettik 2019-07-04 11:42 ` [tarantool-patches] [PATCH v2 3/3] sql: remove VDBE from TXN imeevma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8FEB50DF-9030-41DB-B113-FDDE6EF3B1C1@tarantool.org \ --to=korablev@tarantool.org \ --cc=imeevma@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='[tarantool-patches] Re: [PATCH v2 1/3] sql: remove unnecessary AUTOINCREMENT ID generation' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox