From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/1] iproto: show real port in logs and box.info.listen
Date: Thu, 19 Mar 2020 13:24:20 +0300 [thread overview]
Message-ID: <8DF201C0-3B24-4E49-85D5-86DB34A957CC@tarantool.org> (raw)
In-Reply-To: <9ba81bc4-9ea3-65bd-41c2-924c1fb99881@tarantool.org>
> 19 марта 2020 г., в 01:38, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> написал(а):
>
> Thanks for the review!
>
> On 18/03/2020 19:18, Serge Petrenko wrote:
>> Hi! Thanks for the patch!
>> Alexander asked me to do the 2nd review.
>>
>> The patch LGTM.
>>
>> Sorry for nitpicking, but looks like your changelog request has a typo in it:
>>> @ChangeLog
>>> - box.info.listen - new record in box.info <http://box.info>, which shows a
>>> real port when bound to port 0. For example, if box.cfg
>>> 'listen' parameter was set to '127.0.0.1:0', box.info.listen
>>> will show '127.0.0.1:<real port > 0>' (gh-4620).
>> just <real port>, without 0>, right?
>
> Nope, I meant > 0. I wanted to emphasize, that the port is never
> shown as 0 anymore. It is always some real port > 0.
Ah, I see. Sorry for the misunderstanding.
--
Serge Petrenko
sergepetrenko@tarantool.org
next prev parent reply other threads:[~2020-03-19 10:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 22:03 Vladislav Shpilevoy
2019-11-13 0:32 ` Vladislav Shpilevoy
2019-11-13 22:31 ` Vladislav Shpilevoy
2020-02-21 19:51 ` Sergey Ostanevich
2020-02-22 8:34 ` Sergey Ostanevich
2020-02-22 14:47 ` Vladislav Shpilevoy
2020-02-22 15:00 ` Vladislav Shpilevoy
2020-03-03 13:26 ` Sergey Ostanevich
2020-02-22 15:00 ` Vladislav Shpilevoy
2020-03-18 18:18 ` Serge Petrenko
2020-03-18 22:38 ` Vladislav Shpilevoy
2020-03-19 10:24 ` Serge Petrenko [this message]
2020-03-19 10:45 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8DF201C0-3B24-4E49-85D5-86DB34A957CC@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/1] iproto: show real port in logs and box.info.listen' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox