From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH v8 3/3] sql: remove psql_txn from Vdbe
Date: Tue, 30 Oct 2018 17:30:29 +0300 [thread overview]
Message-ID: <8AB5D4C3-8319-4F19-9A69-68A8819C2B72@tarantool.org> (raw)
In-Reply-To: <ce438a4888b055fa079996319d54dd57adc6eb97.1540832830.git.imeevma@gmail.com>
> It makes no sense to store it here, and it has never
> did.
Nit: this sentence is grammatically incorrect, I guess.
> SQL transaction specific things shall be taken
> from global txn object, as any transaction specific
> things.
> ---
> Issue: https://github.com/tarantool/tarantool/issues/2618
> Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-2618-return-all-generated-ids
>
You don’t need to put links to branch/issue to each patch of patch-set -
you should do it only for covering letter.
Patch itself is OK, but I would either separate this patch from patch-set,
or add "Follow up #xxxx” sign.
next prev parent reply other threads:[~2018-10-30 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 17:33 [tarantool-patches] [PATCH v8 0/3] sql: return all generated ids via IPROTO imeevma
2018-10-29 17:33 ` [tarantool-patches] [PATCH v8 1/3] box: factor fiber_gc out of txn_commit imeevma
2018-10-30 14:30 ` [tarantool-patches] " n.pettik
2018-10-30 19:15 ` Vladislav Shpilevoy
2018-10-30 20:03 ` Vladislav Shpilevoy
2018-10-30 20:06 ` Vladislav Shpilevoy
2018-10-30 21:32 ` Vladislav Shpilevoy
2018-10-30 23:08 ` n.pettik
2018-10-31 9:18 ` Vladislav Shpilevoy
2018-10-31 9:30 ` n.pettik
2018-10-29 17:33 ` [tarantool-patches] [PATCH v8 2/3] sql: return all generated ids via IPROTO imeevma
2018-10-30 14:30 ` [tarantool-patches] " n.pettik
2018-11-02 18:52 ` Imeev Mergen
2018-11-09 7:51 ` n.pettik
2018-10-29 17:33 ` [tarantool-patches] [PATCH v8 3/3] sql: remove psql_txn from Vdbe imeevma
2018-10-30 14:30 ` n.pettik [this message]
2018-10-30 19:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-11-09 8:02 ` [tarantool-patches] Re: [PATCH v8 0/3] sql: return all generated ids via IPROTO Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8AB5D4C3-8319-4F19-9A69-68A8819C2B72@tarantool.org \
--to=korablev@tarantool.org \
--cc=imeevma@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=v.shpilevoy@tarantool.org \
--subject='[tarantool-patches] Re: [PATCH v8 3/3] sql: remove psql_txn from Vdbe' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox