From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> To: tarantool-patches@dev.tarantool.org, avtikhon@tarantool.org Subject: [Tarantool-patches] [PATCH 1/2] test: fix flaky qsync_snapshots.test.lua again Date: Thu, 23 Jul 2020 01:57:01 +0200 [thread overview] Message-ID: <88ecc7da88a4795de6b66281ab96d6cc6a0f7cf4.1595462166.git.v.shpilevoy@tarantool.org> (raw) In-Reply-To: <cover.1595462166.git.v.shpilevoy@tarantool.org> One of the test cases started a sync transaction on master, switched to replica, and tried to do some actions assuming that the latest master data has arrived here. But in fact the replica could be far behind the master. It could still contain data from the previous test case. That led to a bug, when it looked like if the replica had some data committed on it, but not committed on master - this was just data from the previous test case. The issue is solved by flushing master's state to replica via making a successful sync transaction. Closes #5167 --- test/replication/qsync_snapshots.result | 8 +++++++- test/replication/qsync_snapshots.test.lua | 4 +++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/test/replication/qsync_snapshots.result b/test/replication/qsync_snapshots.result index 782ffd482..cafdd63c8 100644 --- a/test/replication/qsync_snapshots.result +++ b/test/replication/qsync_snapshots.result @@ -176,8 +176,14 @@ _ = box.schema.space.create('sync', {is_sync=true, engine=engine}) _ = box.space.sync:create_index('pk') | --- | ... +-- Write something to flush the current master's state to replica. +_ = box.space.sync:insert{1} + | --- + | ... +_ = box.space.sync:delete{1} + | --- + | ... --- Testcase body. test_run:switch('default') | --- | - true diff --git a/test/replication/qsync_snapshots.test.lua b/test/replication/qsync_snapshots.test.lua index 979f04d5f..590610974 100644 --- a/test/replication/qsync_snapshots.test.lua +++ b/test/replication/qsync_snapshots.test.lua @@ -85,8 +85,10 @@ test_run:switch('default') box.cfg{replication_synchro_quorum=NUM_INSTANCES, replication_synchro_timeout=1000} _ = box.schema.space.create('sync', {is_sync=true, engine=engine}) _ = box.space.sync:create_index('pk') +-- Write something to flush the current master's state to replica. +_ = box.space.sync:insert{1} +_ = box.space.sync:delete{1} --- Testcase body. test_run:switch('default') box.cfg{replication_synchro_quorum=BROKEN_QUORUM} ok, err = nil -- 2.21.1 (Apple Git-122.3)
next prev parent reply other threads:[~2020-07-22 23:57 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-22 23:57 [Tarantool-patches] [PATCH 0/2] Qsync flaky tests, next iteration Vladislav Shpilevoy 2020-07-22 23:57 ` Vladislav Shpilevoy [this message] 2020-07-22 23:57 ` [Tarantool-patches] [PATCH 2/2] test: fix flaky qsync_with_anon.test.lua again Vladislav Shpilevoy 2020-07-28 8:09 ` [Tarantool-patches] [PATCH 0/2] Qsync flaky tests, next iteration Alexander V. Tikhonov 2020-07-28 20:37 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=88ecc7da88a4795de6b66281ab96d6cc6a0f7cf4.1595462166.git.v.shpilevoy@tarantool.org \ --to=v.shpilevoy@tarantool.org \ --cc=avtikhon@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 1/2] test: fix flaky qsync_snapshots.test.lua again' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox