From: "n.pettik" <korablev@tarantool.org> To: tarantool-patches@freelists.org Cc: Konstantin Osipov <kostja@tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [tarantool-patches] Re: [PATCH 4/4] sql: raise integer overflow error during msgpack decode Date: Wed, 20 Feb 2019 21:39:38 +0300 [thread overview] Message-ID: <88BEBC9C-84E0-4676-9E42-6E3AB04A0CB9@tarantool.org> (raw) In-Reply-To: <20190220182521.GE3412@chai> > On 20 Feb 2019, at 21:25, Konstantin Osipov <kostja@tarantool.org> wrote: > > * Nikita Pettik <korablev@tarantool.org> [19/02/20 15:12]: >> Since previous commit allows us to raise an error during msgpack decode >> inside VDBE, lets do this if decoded integer is out of >> [INT64_MIN, INT64_MAX] range and set "integer is overflowed" diagnostic >> message. > > This looks OK as interim approach to close 3735, but can't be > accepted as a production-level fix. If SQL can't handle uint64_t > range, SQL tables should not be able to store values from this > range, i.e. there should be an implicitly created constraint on > SQL tables. Better yet is to make sure SQL can handle entire > tarantool range by changing vdbe to emit uint64-range-aware > instructions. It is to be implemented in scope of #3810 issue. Without this patch operations on integers values in range [INT64_MAX, UIN64_MAX] lead to unpredictable results. So, I guess you won’t argue that error raising as at least temporary fix is significantly better than misleading results. > -- > Konstantin Osipov, Moscow, Russia, +7 903 626 22 32 > http://tarantool.io - www.twitter.com/kostja_osipov >
next prev parent reply other threads:[~2019-02-20 18:39 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-20 11:57 [tarantool-patches] [PATCH 0/4] Fix integer overflow behaviour during VDBE execution Nikita Pettik 2019-02-20 11:57 ` [tarantool-patches] [PATCH 1/4] sql: raise an error if int is overflowed during math operations Nikita Pettik 2019-02-20 11:57 ` [tarantool-patches] [PATCH 2/4] sql: raise an integer overflow error during CAST Nikita Pettik 2019-02-20 11:57 ` [tarantool-patches] [PATCH 3/4] sql: refactor sqlVdbeMsgpackGet() Nikita Pettik 2019-02-20 11:57 ` [tarantool-patches] [PATCH 4/4] sql: raise integer overflow error during msgpack decode Nikita Pettik 2019-02-20 18:25 ` [tarantool-patches] " Konstantin Osipov 2019-02-20 18:39 ` n.pettik [this message] 2019-02-20 18:46 ` Konstantin Osipov 2019-02-22 18:30 ` [tarantool-patches] Re: [PATCH 0/4] Fix integer overflow behaviour during VDBE execution Vladislav Shpilevoy 2019-02-25 11:58 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=88BEBC9C-84E0-4676-9E42-6E3AB04A0CB9@tarantool.org \ --to=korablev@tarantool.org \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=v.shpilevoy@tarantool.org \ --subject='[tarantool-patches] Re: [PATCH 4/4] sql: raise integer overflow error during msgpack decode' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox