From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>,
Sergey Bronnikov <estetus@gmail.com>
Cc: max.kokryashkin@gmail.com, tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/2 v2] ci: support coveralls
Date: Wed, 2 Aug 2023 11:20:13 +0300 [thread overview]
Message-ID: <8858f2a0-b703-4641-c1c4-ae49d2dba1a6@tarantool.org> (raw)
In-Reply-To: <trbesdgl3ad5y4iyu4jnalvngp62e3p3i6t36urufvirhbymc2@gpjys54hltis>
Hi, Max
On 8/2/23 11:18, Maxim Kokryashkin via Tarantool-patches wrote:
> Hi, Sergey!
> Thanks for the patch!
> LGTM, except for a few nits regarding the commit message.
>
> Best regards,
> Maxim Kokryashkin
>
> On Tue, Aug 01, 2023 at 09:46:10PM +0300, Sergey Bronnikov via Tarantool-patches wrote:
>> From: Sergey Bronnikov <sergeyb@tarantool.org>
>>
>> The patch adds a workflow that runs regression test suites, produces a
>> summary about current code coverage and send code coverage data to
> Typo: s/about/of/
> Typo: s/send code/sends code/
Fixed!
>> Coveralls. Coveralls is a web-service that lets you inspect every detail
> Typo: s/web-service/web service/
Fixed.
<snipped>
next prev parent reply other threads:[~2023-08-02 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 18:46 [Tarantool-patches] [PATCH 0/2 v2] Add code coverage support Sergey Bronnikov via Tarantool-patches
2023-08-01 18:46 ` [Tarantool-patches] [PATCH 1/2 v2] cmake: add " Sergey Bronnikov via Tarantool-patches
2023-08-02 8:06 ` Maxim Kokryashkin via Tarantool-patches
2023-08-02 8:18 ` Sergey Bronnikov via Tarantool-patches
2023-08-06 11:35 ` Sergey Kaplun via Tarantool-patches
2023-08-07 13:39 ` Sergey Bronnikov via Tarantool-patches
2023-08-15 8:41 ` Maxim Kokryashkin via Tarantool-patches
2023-08-01 18:46 ` [Tarantool-patches] [PATCH 2/2 v2] ci: support coveralls Sergey Bronnikov via Tarantool-patches
2023-08-02 8:18 ` Maxim Kokryashkin via Tarantool-patches
2023-08-02 8:20 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-08-06 11:41 ` Sergey Kaplun via Tarantool-patches
2023-08-07 11:32 ` Sergey Bronnikov via Tarantool-patches
2023-08-21 11:05 ` [Tarantool-patches] [PATCH 0/2 v2] Add code coverage support Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8858f2a0-b703-4641-c1c4-ae49d2dba1a6@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=estetus@gmail.com \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/2 v2] ci: support coveralls' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox