From: "Alexander V. Tikhonov" <avtikhon@tarantool.org> To: Kirill Yukhin <kyukhin@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack Date: Thu, 20 Aug 2020 11:05:57 +0300 [thread overview] Message-ID: <87c28236a265e7ab43072bc89b0a3a11339f7631.1597910696.git.avtikhon@tarantool.org> (raw) ASAN should the issue in msgpuck repository in file test/msgpack.c which was the cause of the fail in unit/msgpack test. The issue was fixed in msgpuck repository and ASAN suppression was removed for it. Also removed skip condition file, which blocked the test when it failed. Part of #4360 --- Github: https://github.com/tarantool/tarantool/tree/avtikhon/asan-restore Issue: https://github.com/tarantool/tarantool/issues/4360 asan/asan.supp | 4 ---- src/lib/msgpuck | 2 +- test/unit/msgpack.skipcond | 7 ------- 3 files changed, 1 insertion(+), 12 deletions(-) delete mode 100644 test/unit/msgpack.skipcond diff --git a/asan/asan.supp b/asan/asan.supp index 24cb0845a..95a662461 100644 --- a/asan/asan.supp +++ b/asan/asan.supp @@ -4,7 +4,3 @@ # File format: #fun:* #src:* - -# !test: unit/msgpack.test -# source: src/lib/msgpuck/test/msgpuck.c -fun:test_mp_print diff --git a/src/lib/msgpuck b/src/lib/msgpuck index 3cc63d3d1..a843861f7 160000 --- a/src/lib/msgpuck +++ b/src/lib/msgpuck @@ -1 +1 @@ -Subproject commit 3cc63d3d1d17c022894d8fb095c5d3dc3ae270aa +Subproject commit a843861f7124f257bbd505fac8dbfb5708ecc855 diff --git a/test/unit/msgpack.skipcond b/test/unit/msgpack.skipcond deleted file mode 100644 index e46fd1088..000000000 --- a/test/unit/msgpack.skipcond +++ /dev/null @@ -1,7 +0,0 @@ -import os - -# Disabled at ASAN build due to issue #4360. -if os.getenv("ASAN") == 'ON': - self.skip = 1 - -# vim: set ft=python: -- 2.17.1
next reply other threads:[~2020-08-20 8:06 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-08-20 8:05 Alexander V. Tikhonov [this message] 2020-09-09 11:36 ` Kirill Yukhin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87c28236a265e7ab43072bc89b0a3a11339f7631.1597910696.git.avtikhon@tarantool.org \ --to=avtikhon@tarantool.org \ --cc=alexander.turenko@tarantool.org \ --cc=kyukhin@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v1] test: remove asan suppression for unit/msgpack' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox