From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL
Date: Fri, 19 Jun 2020 16:01:46 +0300 [thread overview]
Message-ID: <8785dcba-4031-7b34-d159-ec5071cfd3db@tarantool.org> (raw)
In-Reply-To: <20200619122412.GA19725@tarantool.org>
Great, lgtm.
Btw, I didn't try to run tests, I hope you did it.
On 6/19/20 3:24 PM, Nikita Pettik wrote:
>
> Ok, I'm fine with it. Consider this change:
>
> diff --git a/src/box/vy_read_iterator.c b/src/box/vy_read_iterator.c
> index 62a8722d9..409796910 100644
> --- a/src/box/vy_read_iterator.c
> +++ b/src/box/vy_read_iterator.c
> @@ -378,65 +378,6 @@ vy_read_iterator_scan_disk(struct vy_read_iterator *itr, uint32_t disk_src,
> return 0;
> }
next prev parent reply other threads:[~2020-06-19 13:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 16:46 Nikita Pettik
2020-06-01 17:40 ` Vladislav Shpilevoy
2020-06-19 12:34 ` Nikita Pettik
2020-06-20 16:33 ` Vladislav Shpilevoy
2020-06-16 12:10 ` Aleksandr Lyapunov
2020-06-19 12:24 ` Nikita Pettik
2020-06-19 12:42 ` Konstantin Osipov
2020-06-23 5:15 ` Aleksandr Lyapunov
2020-06-23 11:08 ` Konstantin Osipov
2020-06-19 13:01 ` Aleksandr Lyapunov [this message]
2020-06-24 13:41 ` Nikita Pettik
2020-06-20 16:33 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8785dcba-4031-7b34-d159-ec5071cfd3db@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2] vinyl: restart read iterator in case of rolled back WAL' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox