From: Serge Petrenko <sergepetrenko@tarantool.org> To: v.shpilevoy@tarantool.org, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH 3/4] txn_limbo: add timeout when waiting for acks. Date: Thu, 18 Jun 2020 15:14:02 +0300 [thread overview] Message-ID: <87405668347f9bc403be22ba13b4d0a4fdbb80a2.1592482315.git.sergepetrenko@tarantool.org> (raw) In-Reply-To: <cover.1592482315.git.sergepetrenko@tarantool.org> Now txn_limbo_wait_complete() waits for acks only for txn_limbo_confirm_timeout seconds. If a timeout is reached, the entry and all the ones following it must be rolled back. Part-of #4848 --- src/box/txn_limbo.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c index b45068fdd..a715a136e 100644 --- a/src/box/txn_limbo.c +++ b/src/box/txn_limbo.c @@ -128,12 +128,13 @@ txn_limbo_wait_complete(struct txn_limbo *limbo, struct txn_limbo_entry *entry) return; } bool cancellable = fiber_set_cancellable(false); - while (!txn_limbo_entry_is_complete(entry)) - fiber_yield(); + bool timed_out = fiber_yield_timeout(txn_limbo_confirm_timeout(limbo)); fiber_set_cancellable(cancellable); - // TODO: implement rollback. - assert(!entry->is_rollback); - assert(entry->is_commit); + if (timed_out) { + // TODO: implement rollback. + entry->is_rollback = true; + } + assert(txn_limbo_entry_is_complete(entry)); txn_limbo_remove(limbo, entry); txn_clear_flag(txn, TXN_WAIT_ACK); } -- 2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2020-06-18 12:14 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-18 12:13 [Tarantool-patches] [PATCH 0/4] sync replication: add rollback processing Serge Petrenko 2020-06-18 12:14 ` [Tarantool-patches] [PATCH 1/4] xrow: fix comment typo Serge Petrenko 2020-06-18 22:15 ` Vladislav Shpilevoy 2020-06-18 22:15 ` Vladislav Shpilevoy 2020-06-19 17:28 ` Serge Petrenko 2020-06-18 12:14 ` [Tarantool-patches] [PATCH 2/4] xrow: add ability to encode/decode ROLLBACK requests Serge Petrenko 2020-06-18 14:46 ` Cyrill Gorcunov 2020-06-19 17:30 ` Serge Petrenko 2020-06-18 12:14 ` Serge Petrenko [this message] 2020-06-18 12:14 ` [Tarantool-patches] [PATCH 4/4] txn_limbo: add ROLLBACK processing Serge Petrenko 2020-06-18 22:15 ` Vladislav Shpilevoy 2020-06-19 17:35 ` Serge Petrenko 2020-06-21 15:53 ` Vladislav Shpilevoy 2020-06-19 17:53 ` Serge Petrenko 2020-06-23 8:37 ` Serge Petrenko 2020-06-25 22:14 ` Vladislav Shpilevoy 2020-06-25 22:43 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87405668347f9bc403be22ba13b4d0a4fdbb80a2.1592482315.git.sergepetrenko@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH 3/4] txn_limbo: add timeout when waiting for acks.' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox