From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Vladimir Davydov <vdavydov.dev@gmail.com>,
AlexeyIvushkin <ivushkinalex@gmail.com>
Subject: Re: [tarantool-patches] Re: [PATCH] box: add tuple:size function
Date: Sat, 6 Oct 2018 16:58:46 +0300 [thread overview]
Message-ID: <8704964c-ac90-583f-c9ab-fc4dde847184@tarantool.org> (raw)
In-Reply-To: <20181005102321.eyhdkng2ymu5q6jc@esperanza>
On 05/10/2018 13:23, Vladimir Davydov wrote:
> On Thu, Sep 27, 2018 at 08:55:23PM +0300, AlexeyIvushkin wrote:
>> diff --git a/src/box/lua/tuple.lua b/src/box/lua/tuple.lua
>> index 63ea73e..801ee3c 100644
>> --- a/src/box/lua/tuple.lua
>> +++ b/src/box/lua/tuple.lua
>> @@ -286,6 +286,7 @@ local methods = {
>> ["update"] = tuple_update;
>> ["upsert"] = tuple_upsert;
>> ["bsize"] = tuple_bsize;
>> + ["size"] = internal.tuple.size;
>> ["tomap"] = internal.tuple.tuple_to_map;
>
> Why did you decide to introduce a new function rather than fixing
> tuple.bsize, as it was explicitly requested in the ticket?
It breaks compatibility. Now bsize returns only Message Pack part
of tuple despite what the documentation says.
>
next prev parent reply other threads:[~2018-10-06 13:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-27 17:55 [tarantool-patches] " AlexeyIvushkin
2018-10-03 14:20 ` [tarantool-patches] " Vladislav Shpilevoy
2018-10-03 15:05 ` Vladislav Shpilevoy
2018-10-05 10:23 ` [tarantool-patches] " Vladimir Davydov
2018-10-06 13:58 ` Vladislav Shpilevoy [this message]
2018-10-08 10:16 ` [tarantool-patches] " Vladimir Davydov
2018-10-10 10:25 ` Vladislav Shpilevoy
2018-10-16 18:21 ` Konstantin Osipov
2018-10-17 7:28 ` Alexander Turenko
2018-10-17 15:29 ` Konstantin Osipov
2018-10-17 15:50 ` Alexander Turenko
2018-10-18 18:11 ` Konstantin Osipov
2018-10-18 18:15 ` Alexander Turenko
2018-10-17 18:06 ` Vladislav Shpilevoy
2018-10-17 18:10 ` Vladislav Shpilevoy
2018-10-17 18:14 ` Konstantin Osipov
2018-10-17 18:20 ` Alexander Turenko
2018-10-17 20:36 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8704964c-ac90-583f-c9ab-fc4dde847184@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=ivushkinalex@gmail.com \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [tarantool-patches] Re: [PATCH] box: add tuple:size function' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox