Tarantool development patches archive
 help / color / mirror / Atom feed
From: "n.pettik" <korablev@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Konstantin Osipov <kostja@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for CREATE TABLE stmt
Date: Tue, 20 Aug 2019 16:56:49 +0300	[thread overview]
Message-ID: <85AD6E52-BB3D-48A0-9935-4184905A53CA@tarantool.org> (raw)
In-Reply-To: <20190820134918.GB12831@atlas>



> On 20 Aug 2019, at 16:49, Konstantin Osipov <kostja@tarantool.org> wrote:
> 
> * n.pettik <korablev@tarantool.org> [19/08/20 15:15]:
>> 
>> 
>>> On 20 Aug 2019, at 14:57, Konstantin Osipov <kostja@tarantool.org> wrote:
>>> 
>>> * Nikita Pettik <korablev@tarantool.org> [19/08/19 17:54]:
>>>> Branch: https://github.com/tarantool/tarantool/issues/4422
>>>> Issue: https://github.com/tarantool/tarantool/tree/np/gh-4422-with-engine-option
>>>> 
>>> 
>>> I am utterly disappointed with the fact that instead of fixing a
>>> broken feature that is already there and have been waiting years
>>> for a fix
>> 
>> What feature exactly are you talking about?
> 
> The one we discussed and agreed on, set engine=‘vinyl'

It’s about default engine, not per table option.

Speaking of ‘waiting years for a fix’ - there’s no even corresponding issue
except for one which you created last week.

>>> you spend time on working on a new feature
>> 
>> It was done in one day, not so much time spent I guess.
>> 
>>> which *no one* except your highly aesthetic self has asked for :(
>> 
>> Every week I see questions in public chat like “how to create vinyl table
>> using SQL facilities” and that’s a fact.
> 
> The answer should be: use set engine='vinyl'.
> 
> -- 
> Konstantin Osipov, Moscow, Russia
> 

  reply	other threads:[~2019-08-20 13:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 14:49 [tarantool-patches] " Nikita Pettik
2019-08-19 14:49 ` [tarantool-patches] [PATCH 1/2] Do not log error in engine_find() Nikita Pettik
2019-08-19 14:49 ` [tarantool-patches] [PATCH 2/2] sql: allow to specify engine in CREATE TABLE stmt Nikita Pettik
2019-08-20 11:59   ` [tarantool-patches] " Konstantin Osipov
2019-08-19 21:05 ` [tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for " Vladislav Shpilevoy
2019-08-20 11:57 ` Konstantin Osipov
2019-08-20 12:10   ` n.pettik
2019-08-20 13:49     ` Konstantin Osipov
2019-08-20 13:56       ` n.pettik [this message]
2019-08-20 13:59         ` Konstantin Osipov
2019-08-22 12:07 ` Kirill Yukhin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85AD6E52-BB3D-48A0-9935-4184905A53CA@tarantool.org \
    --to=korablev@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 0/2] Introduce WITH ENGINE option for CREATE TABLE stmt' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox