Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Konstantin Osipov <kostja@tarantool.org>
Cc: tarantool-patches@freelists.org
Subject: [tarantool-patches] Re: [PATCH v2 4/4] Extract 'coll' library from 'core'
Date: Tue, 26 Feb 2019 15:37:16 +0300	[thread overview]
Message-ID: <85771fa1-b999-e3d0-3975-44e8a3d371cd@tarantool.org> (raw)
In-Reply-To: <20190226122357.GF5592@chai>



On 26/02/2019 15:23, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/02/26 15:16]:
>> Core is supposed to be the most basic library, providing only
>> really common features used everywhere like fiber, diag, memory,
>> logging. Which can't be said about collations - they are used
>> only by high level things - SQL, Lua utf8, comparators.
>>
>> Collations are built now as 'lib/coll' library.
> 
> Does it depend on core or compile without it?

As you can see in src/lib/coll/CMakeLists.txt, it depends on
core. Because of diag.

> The same question
> applies to http_parser.

http_parser does not depend on core.

> I think as a follow up we also need to put
> a small README file in each dir describing the purpose of each
> library and what other key libraries it depends on.

We usually do not put such dependency links in any
library headers. A programmer can look at CMakeLists,
if he needs to know them. Secondly, it complicates update -
when we added or removed a dependency, we would have
had to update two files - source and CMakeLists.txt.
Thirdly, even if you added as a dependency a static library,
but did not add its own dependencies, it is ok - cmake
handles that.

> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
> 

  reply	other threads:[~2019-02-26 12:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 12:11 [tarantool-patches] [PATCH v2 0/4] Move 'core' lib to src/lib Vladislav Shpilevoy
2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 1/4] Remove dead dependency of http_parser on httpc Vladislav Shpilevoy
2019-02-26 12:12   ` [tarantool-patches] " Vladislav Shpilevoy
2019-02-26 12:21   ` Konstantin Osipov
2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 2/4] Move 'http_parser' to src/lib Vladislav Shpilevoy
2019-02-26 12:21   ` [tarantool-patches] " Konstantin Osipov
2019-02-26 16:57     ` Vladislav Shpilevoy
2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 3/4] Move 'core' and 'uuid' libs " Vladislav Shpilevoy
2019-02-26 12:22   ` [tarantool-patches] " Konstantin Osipov
2019-02-26 16:57     ` Vladislav Shpilevoy
2019-02-26 12:11 ` [tarantool-patches] [PATCH v2 4/4] Extract 'coll' library from 'core' Vladislav Shpilevoy
2019-02-26 12:23   ` [tarantool-patches] " Konstantin Osipov
2019-02-26 12:37     ` Vladislav Shpilevoy [this message]
2019-02-26 12:55       ` Konstantin Osipov
2019-02-26 13:09         ` Vladislav Shpilevoy
2019-02-26 13:17           ` Konstantin Osipov
2019-02-26 13:43             ` Vladislav Shpilevoy
2019-02-27 15:07               ` Vladislav Shpilevoy
2019-02-26 16:55 ` [tarantool-patches] [PATCH 1/1] Move 'info' library to src/lib Vladislav Shpilevoy
2019-02-26 22:08   ` [tarantool-patches] " Konstantin Osipov
2019-02-27 15:07     ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85771fa1-b999-e3d0-3975-44e8a3d371cd@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=kostja@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH v2 4/4] Extract '\''coll'\'' library from '\''core'\''' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox