[tarantool-patches] Re: [PATCH v2 4/4] Extract 'coll' library from 'core'

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

On 26/02/2019 15:23, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/02/26 15:16]:
>> Core is supposed to be the most basic library, providing only
>> really common features used everywhere like fiber, diag, memory,
>> logging. Which can't be said about collations - they are used
>> only by high level things - SQL, Lua utf8, comparators.
>>
>> Collations are built now as 'lib/coll' library.
> 
> Does it depend on core or compile without it?

As you can see in src/lib/coll/CMakeLists.txt, it depends on
core. Because of diag.

> The same question
> applies to http_parser.

http_parser does not depend on core.

> I think as a follow up we also need to put
> a small README file in each dir describing the purpose of each
> library and what other key libraries it depends on.

We usually do not put such dependency links in any
library headers. A programmer can look at CMakeLists,
if he needs to know them. Secondly, it complicates update -
when we added or removed a dependency, we would have
had to update two files - source and CMakeLists.txt.
Thirdly, even if you added as a dependency a static library,
but did not add its own dependencies, it is ok - cmake
handles that.

> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>