From: Stanislav Zudin <szudin@tarantool.org> To: tarantool-patches@freelists.org, vdavydov.dev@gmail.com Cc: Stanislav Zudin <szudin@tarantool.org> Subject: [PATCH 09/13] sql: fixes errors Date: Fri, 15 Mar 2019 18:45:38 +0300 [thread overview] Message-ID: <85476cfaec30d5958cfbd24c89ad4475bea2d3ed.1552663061.git.szudin@tarantool.org> (raw) In-Reply-To: <cover.1552663061.git.szudin@tarantool.org> In-Reply-To: <cover.1552663061.git.szudin@tarantool.org> Fixes an error in sql_value_type() and wrong arguments order in arithmetic operations. --- src/box/sql/vdbe.c | 10 +++++----- src/box/sql/vdbeapi.c | 3 ++- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c index d4bd845fb..ad2ce1787 100644 --- a/src/box/sql/vdbe.c +++ b/src/box/sql/vdbe.c @@ -1677,11 +1677,11 @@ case OP_Remainder: { /* same as TK_REM, in1, in2, out3 */ bIntint = 1; enum arithmetic_result arr; switch( pOp->opcode) { - case OP_Add: arr = sqlAddInt64(&iB, is_signedA, iA, is_signedB); break; - case OP_Subtract: arr = sqlSubInt64(&iB, is_signedA, iA, is_signedB); break; - case OP_Multiply: arr = sqlMulInt64(&iB, is_signedA, iA, is_signedB); break; - case OP_Divide: arr = sqlDivInt64(&iB, is_signedA, iA, is_signedB); break; - default: arr = sqlRemInt64(&iB, is_signedA, iA, is_signedB); break; + case OP_Add: arr = sqlAddInt64(&iB, is_signedB, iA, is_signedA); break; + case OP_Subtract: arr = sqlSubInt64(&iB, is_signedB, iA, is_signedA); break; + case OP_Multiply: arr = sqlMulInt64(&iB, is_signedB, iA, is_signedA); break; + case OP_Divide: arr = sqlDivInt64(&iB, is_signedB, iA, is_signedA); break; + default: arr = sqlRemInt64(&iB, is_signedB, iA, is_signedA); break; } switch(arr){ diff --git a/src/box/sql/vdbeapi.c b/src/box/sql/vdbeapi.c index 6a3413954..06140569c 100644 --- a/src/box/sql/vdbeapi.c +++ b/src/box/sql/vdbeapi.c @@ -319,7 +319,8 @@ sql_value_type(sql_value * pVal) * type bits, to make them applicable for * array indexing. */ - u32 offset = (pVal->flags >> 12) | (pVal->flags & MEM_PURE_TYPE_MASK); + u32 offset = ((pVal->flags & MEM_Unsigned) >> 12) | + (pVal->flags & MEM_PURE_TYPE_MASK); assert(offset < 0x40); return aType[offset]; } -- 2.17.1
next prev parent reply other threads:[~2019-03-15 15:45 UTC|newest] Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-15 15:45 [PATCH 00/13] sql: support -2^63 .. 2^64-1 integer type Stanislav Zudin 2019-03-15 15:45 ` [PATCH 01/13] sql: Convert big integers from string Stanislav Zudin 2019-03-25 15:10 ` [tarantool-patches] " n.pettik 2019-04-01 20:39 ` Stanislav Zudin 2019-04-02 7:27 ` Konstantin Osipov 2019-03-15 15:45 ` [PATCH 02/13] sql: make VDBE recognize big integers Stanislav Zudin 2019-03-25 15:11 ` [tarantool-patches] " n.pettik 2019-04-01 20:42 ` Stanislav Zudin 2019-04-02 7:38 ` [tarantool-patches] " Konstantin Osipov 2019-03-15 15:45 ` [PATCH 03/13] sql: removes unused function Stanislav Zudin 2019-03-25 15:11 ` [tarantool-patches] " n.pettik 2019-04-01 20:39 ` Stanislav Zudin 2019-03-15 15:45 ` [PATCH 04/13] sql: support big integers within sql binding Stanislav Zudin 2019-03-25 15:12 ` [tarantool-patches] " n.pettik 2019-04-01 20:42 ` Stanislav Zudin 2019-04-02 7:46 ` Konstantin Osipov 2019-04-02 7:44 ` [tarantool-patches] " Konstantin Osipov 2019-03-15 15:45 ` [PATCH 05/13] sql: removes redundant function Stanislav Zudin 2019-03-25 15:12 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 06/13] sql: aux functions to support big integers Stanislav Zudin 2019-03-25 15:13 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 07/13] sql: arithmetic functions " Stanislav Zudin 2019-03-25 15:13 ` [tarantool-patches] " n.pettik 2019-04-01 20:43 ` Stanislav Zudin 2019-04-02 7:54 ` Konstantin Osipov 2019-04-02 7:52 ` Konstantin Osipov 2019-03-15 15:45 ` [PATCH 08/13] sql: aggregate sql functions support big int Stanislav Zudin 2019-03-25 15:13 ` [tarantool-patches] " n.pettik 2019-04-01 20:43 ` Stanislav Zudin 2019-04-02 7:57 ` [tarantool-patches] " Konstantin Osipov 2019-03-15 15:45 ` Stanislav Zudin [this message] 2019-03-25 15:14 ` [tarantool-patches] Re: [PATCH 09/13] sql: fixes errors n.pettik 2019-03-15 15:45 ` [PATCH 10/13] sql: fixes an error in sqlSubInt64 Stanislav Zudin 2019-03-25 15:14 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 11/13] sql: fixes an error in string to int64 conversion Stanislav Zudin 2019-03-25 15:14 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 12/13] sql: fixes an error in uint64 to double casting Stanislav Zudin 2019-03-25 15:15 ` [tarantool-patches] " n.pettik 2019-03-15 15:45 ` [PATCH 13/13] sql: support -2^63 .. 2^64-1 integer type Stanislav Zudin 2019-03-25 15:25 ` [tarantool-patches] " n.pettik 2019-04-01 20:44 ` Stanislav Zudin 2019-03-25 15:10 ` [tarantool-patches] Re: [PATCH 00/13] " n.pettik 2019-04-01 20:38 ` Stanislav Zudin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=85476cfaec30d5958cfbd24c89ad4475bea2d3ed.1552663061.git.szudin@tarantool.org \ --to=szudin@tarantool.org \ --cc=tarantool-patches@freelists.org \ --cc=vdavydov.dev@gmail.com \ --subject='Re: [PATCH 09/13] sql: fixes errors' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox