From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: sergepetrenko <sergepetrenko@tarantool.org>, georgy@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/5] introduce anonymous replicas
Date: Sun, 22 Dec 2019 18:59:15 +0100 [thread overview]
Message-ID: <84fcecd3-af3b-8001-ed91-14b07f57e06a@tarantool.org> (raw)
In-Reply-To: <cover.1576443171.git.sergepetrenko@tarantool.org>
Hi! Thanks for the patch, overall it looks cool.
It would be cool to have a brief explanations of what
was done in the patchset.
Sorry, I didn't add my fixes on top of your commits,
because I am afraid it may complicate reverting some
of them, because you know replication code better than
me and I may be wrong somewhere. I will do fixes in case
after this review only some extra minor comments will
remain.
On 15/12/2019 21:56, sergepetrenko wrote:
> Serge Petrenko (3):
> box: update comment describing join protocol
> replication: do not decode replicaset uuid when processing a subscribe
> applier: split join processing into two stages
>
> sergepetrenko (2):
> vclock: ignore 0th component in comparisons.
> replication: introduce anonymous replica.
Seems like you authored the commits from 2 different
accounts: sergepetrenko and Serge Petrenko. Please,
choose one.
prev parent reply other threads:[~2019-12-22 17:59 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 20:56 sergepetrenko
2019-12-15 20:58 ` [Tarantool-patches] [PATCH 1/5] box: update comment describing join protocol sergepetrenko
2019-12-22 17:58 ` Vladislav Shpilevoy
2019-12-23 21:12 ` Sergey Petrenko
2019-12-15 20:58 ` [Tarantool-patches] [PATCH 2/5] replication: do not decode replicaset uuid when processing a subscribe sergepetrenko
2019-12-15 20:58 ` [Tarantool-patches] [PATCH 3/5] applier: split join processing into two stages sergepetrenko
2019-12-22 17:59 ` Vladislav Shpilevoy
2019-12-23 22:10 ` Sergey Petrenko
2019-12-24 15:50 ` Vladislav Shpilevoy
2019-12-15 20:58 ` [Tarantool-patches] [PATCH 4/5] vclock: ignore 0th component in comparisons sergepetrenko
2019-12-22 17:59 ` Vladislav Shpilevoy
2019-12-23 21:26 ` Sergey Petrenko
2019-12-23 22:58 ` Sergey Petrenko
2019-12-26 4:43 ` Konstantin Osipov
2019-12-26 5:02 ` Konstantin Osipov
2019-12-27 12:56 ` Sergey Petrenko
2019-12-27 13:31 ` Konstantin Osipov
2019-12-27 13:48 ` Sergey Petrenko
2019-12-27 14:40 ` Konstantin Osipov
2019-12-15 20:58 ` [Tarantool-patches] [PATCH 5/5] replication: introduce anonymous replica sergepetrenko
2019-12-16 13:28 ` Serge Petrenko
2019-12-20 12:06 ` Serge Petrenko
2019-12-22 17:58 ` Vladislav Shpilevoy
2019-12-25 12:40 ` Sergey Petrenko
2019-12-25 18:23 ` Vladislav Shpilevoy
2019-12-26 16:08 ` Sergey Petrenko
2019-12-15 21:00 ` [Tarantool-patches] [PATCH 0/5] introduce anonymous replicas Sergey Petrenko
2019-12-18 7:49 ` Georgy Kirichenko
2019-12-20 12:07 ` Serge Petrenko
2019-12-20 12:17 ` Serge Petrenko
2019-12-22 17:59 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84fcecd3-af3b-8001-ed91-14b07f57e06a@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=georgy@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/5] introduce anonymous replicas' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox