From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/2] Validate result of upserts squash & skip invalid upserts which can't be applied
Date: Tue, 23 Jun 2020 15:32:29 +0300 [thread overview]
Message-ID: <8489bdc4-a128-212b-9da2-f6101cd825a0@tarantool.org> (raw)
In-Reply-To: <20200622202108.GA32744@tarantool.org>
>> I bet we should just remove assert here. If mem_stmt have
>> a valid LSN now - it is a valid statement. The first of them must
>> have n_upserts=0, the second - 1 etc, and n_upsert of following
>> prepared statements must continue the sequence.
> What is the point of keeping counting n_upserts for upserts
> which can't be squashed? For sure we can simply remove assertion,
> but then after accumulating more than 128 upserts which can't
> be applied, vy_squash_process won't be called till dump...
>
Why can't? After accumulating more 128 upserts squash process
must be restarted and squash those upserts that became committed.
next prev parent reply other threads:[~2020-06-23 12:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-13 21:55 Nikita Pettik
2020-04-13 21:55 ` [Tarantool-patches] [PATCH 1/2] vinyl: validate resulting tuple after upsert is applied Nikita Pettik
2020-06-22 19:28 ` Aleksandr Lyapunov
2020-04-13 21:55 ` [Tarantool-patches] [PATCH 2/2] vinyl: skip invalid upserts during squash Nikita Pettik
2020-04-13 22:12 ` Konstantin Osipov
2020-05-14 2:11 ` Nikita Pettik
2020-05-14 6:56 ` Konstantin Osipov
2020-05-19 19:10 ` Nikita Pettik
2020-05-19 19:39 ` Konstantin Osipov
2020-05-21 2:51 ` Nikita Pettik
2020-05-21 8:36 ` Konstantin Osipov
2020-05-01 0:31 ` Vladislav Shpilevoy
2020-05-14 2:21 ` Nikita Pettik
2020-05-14 21:32 ` Vladislav Shpilevoy
2020-05-19 18:18 ` Nikita Pettik
2020-05-20 22:13 ` Vladislav Shpilevoy
2020-05-26 21:33 ` Vladislav Shpilevoy
2020-05-27 20:05 ` Nikita Pettik
2020-05-29 21:47 ` Vladislav Shpilevoy
2020-06-01 19:24 ` Nikita Pettik
2020-05-20 22:13 ` [Tarantool-patches] [PATCH 0/2] Validate result of upserts squash & skip invalid upserts which can't be applied Vladislav Shpilevoy
2020-05-22 2:42 ` Nikita Pettik
2020-05-26 21:33 ` Vladislav Shpilevoy
2020-05-27 20:10 ` Nikita Pettik
2020-06-22 14:13 ` Aleksandr Lyapunov
2020-06-22 20:21 ` Nikita Pettik
2020-06-23 12:32 ` Aleksandr Lyapunov [this message]
2020-06-02 21:36 ` Vladislav Shpilevoy
2020-06-02 21:37 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8489bdc4-a128-212b-9da2-f6101cd825a0@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=korablev@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] Validate result of upserts squash & skip invalid upserts which can'\''t be applied' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox