Tarantool development patches archive
 help / color / mirror / Atom feed
From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v4 13/16] box: allow calling promote on a candidate
Date: Thu, 15 Jul 2021 17:06:08 +0300	[thread overview]
Message-ID: <84409aa0-bdab-2cce-66d5-e09092eeb85c@tarantool.org> (raw)
In-Reply-To: <5e258b337c1314a10440677b583290d94fc4f499.1626287002.git.sergepetrenko@tarantool.org>



14.07.2021 21:25, Serge Petrenko пишет:
> Part of #6034
> ---
>   src/box/box.cc                                | 15 +---
>   .../gh-6034-election-candidate-promote.result | 84 +++++++++++++++++++
>   ...h-6034-election-candidate-promote.test.lua | 42 ++++++++++
>   test/replication/suite.cfg                    |  1 +
>   4 files changed, 128 insertions(+), 14 deletions(-)
>   create mode 100644 test/replication/gh-6034-election-candidate-promote.result
>   create mode 100644 test/replication/gh-6034-election-candidate-promote.test.lua
>

Fixed an obvious typo:

=========================

diff --git a/test/replication/gh-6034-election-candidate-promote.result 
b/test/replication/gh-6034-election-candidate-promote.result
index 76a54d5a6..2b4bc0213 100644
--- a/test/replication/gh-6034-election-candidate-promote.result
+++ b/test/replication/gh-6034-election-candidate-promote.result
@@ -60,7 +60,7 @@ next_nr = leader_nr % 3 + 1
   | ...
  -- Someone else may become a leader, thus promote may fail. But we're 
testing
  -- that it takes effect at all, so that's fine.
-_ = pcall(test_run:eval('election_replica'..next_nr, 'box.ctl.promote()'))
+_ = pcall(test_run.eval, test_run, 'election_replica'..next_nr, 
'box.ctl.promote()')
   | ---
   | ...
  new_term = test_run:eval('election_replica'..next_nr,\
diff --git 
a/test/replication/gh-6034-election-candidate-promote.test.lua 
b/test/replication/gh-6034-election-candidate-promote.test.lua
index 24c57f4cb..c25f9296d 100644
--- a/test/replication/gh-6034-election-candidate-promote.test.lua
+++ b/test/replication/gh-6034-election-candidate-promote.test.lua
@@ -32,7 +32,7 @@ term = test_run:eval('election_replica'..leader_nr,\
  next_nr = leader_nr % 3 + 1
  -- Someone else may become a leader, thus promote may fail. But we're 
testing
  -- that it takes effect at all, so that's fine.
-_ = pcall(test_run:eval('election_replica'..next_nr, 'box.ctl.promote()'))
+_ = pcall(test_run.eval, test_run, 'election_replica'..next_nr, 
'box.ctl.promote()')
  new_term = test_run:eval('election_replica'..next_nr,\
                           'return box.info.election.term')[1]
  assert(new_term > term)

=========================

-- 
Serge Petrenko


  reply	other threads:[~2021-07-15 14:06 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 18:25 [Tarantool-patches] [PATCH v4 00/16] forbid implicit limbo ownership transition Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 01/16] replication: always send raft state to subscribers Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 02/16] txn_limbo: fix promote term filtering Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 03/16] txn_limbo: persist the latest effective promote in snapshot Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 04/16] replication: encode version in JOIN request Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 05/16] replication: add META stage to JOIN Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 06/16] replication: send latest effective promote in initial join Serge Petrenko via Tarantool-patches
2021-07-21 23:24   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-23  7:44     ` Sergey Petrenko via Tarantool-patches
2021-07-26 23:43       ` Vladislav Shpilevoy via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 07/16] replication: send current Raft term in join response Serge Petrenko via Tarantool-patches
2021-07-21 23:24   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-23  7:44     ` Sergey Petrenko via Tarantool-patches
2021-07-26 23:43       ` Vladislav Shpilevoy via Tarantool-patches
2021-07-29 20:46         ` Sergey Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 08/16] raft: refactor raft_new_term() Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 09/16] box: split promote() into reasonable parts Serge Petrenko via Tarantool-patches
2021-07-21 23:26   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-23  7:45     ` Sergey Petrenko via Tarantool-patches
2021-07-26 23:44       ` Vladislav Shpilevoy via Tarantool-patches
2021-07-29 20:46         ` Sergey Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 10/16] box: make promote always bump the term Serge Petrenko via Tarantool-patches
2021-07-26 23:45   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-29 20:46     ` Sergey Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 11/16] box: make promote on the current leader a no-op Serge Petrenko via Tarantool-patches
2021-07-21 23:26   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-23  7:45     ` Sergey Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 12/16] box: fix an assertion failure after a spurious wakeup in promote Serge Petrenko via Tarantool-patches
2021-07-21 23:29   ` Vladislav Shpilevoy via Tarantool-patches
2021-07-23  7:45     ` Sergey Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 13/16] box: allow calling promote on a candidate Serge Petrenko via Tarantool-patches
2021-07-15 14:06   ` Serge Petrenko via Tarantool-patches [this message]
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 14/16] box: extract promote() settings to a separate method Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 15/16] replication: forbid implicit limbo owner transition Serge Petrenko via Tarantool-patches
2021-07-14 18:25 ` [Tarantool-patches] [PATCH v4 16/16] box: introduce `box.ctl.demote` Serge Petrenko via Tarantool-patches
2021-07-15 17:13   ` Serge Petrenko via Tarantool-patches
2021-07-15 20:11   ` [Tarantool-patches] [PATCH v4 17/16] replication: fix flaky election_qsync.test Serge Petrenko via Tarantool-patches
2021-07-26 23:43 ` [Tarantool-patches] [PATCH v4 00/16] forbid implicit limbo ownership transition Vladislav Shpilevoy via Tarantool-patches
2021-07-29 20:47   ` Sergey Petrenko via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84409aa0-bdab-2cce-66d5-e09092eeb85c@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=v.shpilevoy@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v4 13/16] box: allow calling promote on a candidate' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox