From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [PATCH v2 03/10] box: fix certain cfg options initialized twice on recovery Date: Sat, 8 Dec 2018 18:48:07 +0300 [thread overview] Message-ID: <840b3031c7164aaa95522cc591213eaac6659c82.1544282224.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1544282224.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1544282224.git.vdavydov.dev@gmail.com> Certain dynamic configuration options are initialized right in box.cc, because they are needed for recovery. All such options are supposed to be present in dynamic_cfg_skip_at_load table so that load_cfg.lua won't try to set them again upon recovery completion. However, not all of them happen to be there - sometime we simply forgot to patch this table after introduction of a new configuration option. This patch adds all the missing ones except checkpoint_count - there's no point to initialize checkpoint_count in box.cc so it removes it from box.cc instead. --- src/box/box.cc | 1 - src/box/lua/load_cfg.lua | 8 +++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/box/box.cc b/src/box/box.cc index 20412af4..036769a9 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -2073,7 +2073,6 @@ box_cfg_xc(void) box_check_replicaset_uuid(&replicaset_uuid); box_set_net_msg_max(); - box_set_checkpoint_count(); box_set_too_long_threshold(); box_set_replication_timeout(); box_set_replication_connect_timeout(); diff --git a/src/box/lua/load_cfg.lua b/src/box/lua/load_cfg.lua index fd99206f..38e742c8 100644 --- a/src/box/lua/load_cfg.lua +++ b/src/box/lua/load_cfg.lua @@ -250,21 +250,27 @@ local dynamic_cfg = { } local dynamic_cfg_skip_at_load = { - wal_mode = true, listen = true, memtx_memory = true, + memtx_max_tuple_size = true, vinyl_memory = true, + vinyl_max_tuple_size = true, + vinyl_cache = true, + vinyl_timeout = true, + too_long_threshold = true, replication = true, replication_timeout = true, replication_connect_timeout = true, replication_connect_quorum = true, replication_sync_lag = true, replication_sync_timeout = true, + replication_skip_conflict = true, wal_dir_rescan_delay = true, custom_proc_title = true, force_recovery = true, instance_uuid = true, replicaset_uuid = true, + net_msg_max = true, } local function convert_gb(size) -- 2.11.0
next prev parent reply other threads:[~2018-12-08 15:48 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-08 15:48 [PATCH v2 00/10] Allow to limit size of WAL files Vladimir Davydov 2018-12-08 15:48 ` [PATCH v2 01/10] gc: do not use WAL watcher API for deactivating stale consumers Vladimir Davydov 2018-12-08 21:41 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 02/10] wal: simplify watcher API Vladimir Davydov 2018-12-08 21:41 ` Konstantin Osipov 2018-12-08 15:48 ` Vladimir Davydov [this message] 2018-12-08 21:42 ` [PATCH v2 03/10] box: fix certain cfg options initialized twice on recovery Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 04/10] box: don't use box_checkpoint_is_in_progress outside box.cc Vladimir Davydov 2018-12-08 21:43 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 05/10] box: move checkpointing to gc module Vladimir Davydov 2018-12-08 21:44 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 06/10] gc: some renames Vladimir Davydov 2018-12-08 21:44 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 07/10] Introduce checkpoint schedule module Vladimir Davydov 2018-12-08 21:45 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 08/10] Rewrite checkpoint daemon in C Vladimir Davydov 2018-12-08 21:45 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 09/10] wal: pass struct instead of vclock to checkpoint methods Vladimir Davydov 2018-12-08 21:46 ` Konstantin Osipov 2018-12-08 15:48 ` [PATCH v2 10/10] wal: trigger checkpoint if there are too many WALs Vladimir Davydov 2018-12-08 21:48 ` Konstantin Osipov 2018-12-09 11:20 ` [PATCH v2 00/10] Allow to limit size of WAL files Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=840b3031c7164aaa95522cc591213eaac6659c82.1544282224.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [PATCH v2 03/10] box: fix certain cfg options initialized twice on recovery' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox