Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: alexander.turenko@tarantool.org
Subject: [tarantool-patches] Re: [PATCH 2/2] wal: drop rows_per_wal option
Date: Sun, 8 Sep 2019 14:53:42 +0200	[thread overview]
Message-ID: <8403c1b5-feca-f008-a710-39370f5e9781@tarantool.org> (raw)
In-Reply-To: <ab4bf2c766c751da35c66104ee8407a54ef0e801.1567872249.git.v.shpilevoy@tarantool.org>

Changed a constant and its comment, as asked by Kostja:

diff --git a/src/box/wal.h b/src/box/wal.h
index 2ddc008ff..b76b0a41f 100644
--- a/src/box/wal.h
+++ b/src/box/wal.h
@@ -45,13 +45,11 @@ enum wal_mode { WAL_NONE = 0, WAL_WRITE, WAL_FSYNC, WAL_MODE_MAX };
 
 enum {
 	/**
-	 * Such a value originates from the old setting
-	 * 'rows_per_wal'. By default it was 500000, and its
-	 * value was used to decide how often wal writer needs
-	 * to yield, by formula: (rows_per_wal >> 4) + 1. With
-	 * default rows_per_wal it was equal to this constant.
+	 * Recovery yields once per that number of rows read and
+	 * applied from WAL. It allows not to block the event
+	 * loop for the whole recovery stage.
 	 */
-	WAL_ROWS_PER_YIELD = 31251,
+	WAL_ROWS_PER_YIELD = 32000,
 };

      reply	other threads:[~2019-09-08 12:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-07 16:05 [tarantool-patches] [PATCH 0/2] Deprecate rows_per_wal Vladislav Shpilevoy
2019-09-07 16:05 ` [tarantool-patches] [PATCH 1/2] wal: deprecate rows_per_wal in favour of wal_max_size Vladislav Shpilevoy
2019-09-08 12:53   ` [tarantool-patches] " Vladislav Shpilevoy
2019-09-10 18:50   ` Kirill Yukhin
2019-09-07 16:05 ` [tarantool-patches] [PATCH 2/2] wal: drop rows_per_wal option Vladislav Shpilevoy
2019-09-08 12:53   ` Vladislav Shpilevoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8403c1b5-feca-f008-a710-39370f5e9781@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=alexander.turenko@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='[tarantool-patches] Re: [PATCH 2/2] wal: drop rows_per_wal option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox