From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Chris Sosnin <k.sosnin@tarantool.org>,
tarantool-patches@dev.tarantool.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sequence: return correct error on using dropped sequence
Date: Sat, 29 Feb 2020 16:43:33 +0100 [thread overview]
Message-ID: <83fa4b26-3f6d-ce5c-56eb-4c2034004576@tarantool.org> (raw)
In-Reply-To: <20200226161308.73170-1-k.sosnin@tarantool.org>
LGTM.
On 26/02/2020 17:13, Chris Sosnin wrote:
> This code is called from C, so it shouldn't throw.
>
> Closes #4753
> ---
> branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4753-sequence-cpp-exception
> issue: https://github.com/tarantool/tarantool/issues/4753
>
> src/box/schema.cc | 2 +-
> test/box/sequence.result | 17 +++++++++++++++++
> test/box/sequence.test.lua | 8 ++++++++
> 3 files changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/src/box/schema.cc b/src/box/schema.cc
> index fab7544f2..456eef429 100644
> --- a/src/box/schema.cc
> +++ b/src/box/schema.cc
> @@ -646,7 +646,7 @@ sequence_cache_find(uint32_t id)
> {
> struct sequence *seq = sequence_by_id(id);
> if (seq == NULL)
> - tnt_raise(ClientError, ER_NO_SUCH_SEQUENCE, int2str(id));
> + diag_set(ClientError, ER_NO_SUCH_SEQUENCE, int2str(id));
> return seq;
> }
>
> diff --git a/test/box/sequence.result b/test/box/sequence.result
> index 0a6cfee2c..32a094d6f 100644
> --- a/test/box/sequence.result
> +++ b/test/box/sequence.result
> @@ -2102,6 +2102,23 @@ s:drop()
> ---
> ...
> --
> +-- gh-4753: accessing dropped sequence should yield correct error
> +--
> +s = box.schema.sequence.create('s')
> +---
> +...
> +s:drop()
> +---
> +...
> +s:next()
> +---
> +- error: Sequence '1' does not exist
> +...
> +s:reset()
> +---
> +- error: Sequence '1' does not exist
> +...
> +--
> -- Check that altering parts of a primary index with a sequence
> -- attached requires sequence update. Renaming fields does not.
> --
> diff --git a/test/box/sequence.test.lua b/test/box/sequence.test.lua
> index 8e00571e5..d8a212fab 100644
> --- a/test/box/sequence.test.lua
> +++ b/test/box/sequence.test.lua
> @@ -710,6 +710,14 @@ s.index.pk:alter{sequence = {field = 'x.a.b[1]'}}
> s:replace{{a = {b = {box.NULL}}}} -- ok
> s:drop()
>
> +--
> +-- gh-4753: accessing dropped sequence should yield correct error
> +--
> +s = box.schema.sequence.create('s')
> +s:drop()
> +s:next()
> +s:reset()
> +
> --
> -- Check that altering parts of a primary index with a sequence
> -- attached requires sequence update. Renaming fields does not.
>
next prev parent reply other threads:[~2020-02-29 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 16:13 Chris Sosnin
2020-02-29 15:43 ` Vladislav Shpilevoy [this message]
2020-03-02 10:59 ` Nikita Pettik
2020-03-02 15:25 ` Chris Sosnin
2020-03-16 13:43 ` Nikita Pettik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83fa4b26-3f6d-ce5c-56eb-4c2034004576@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=k.sosnin@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] sequence: return correct error on using dropped sequence' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox