From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@freelists.org,
Konstantin Belyavskiy <k.belyavskiy@tarantool.org>,
vdavydov@tarantool.org, georgy@tarantool.org
Subject: Re: [tarantool-patches] [PATCH] replication: fix broken cases with quorum=0
Date: Tue, 17 Apr 2018 21:09:51 +0300 [thread overview]
Message-ID: <83d14f21-22bf-da6f-d6bc-7c76a3682c59@tarantool.org> (raw)
In-Reply-To: <20180417140726.91732-1-k.belyavskiy@tarantool.org>
Hello, see my comments below.
On 17/04/2018 17:07, Konstantin Belyavskiy wrote:
> Ticket: https://github.com/tarantool/tarantool/issues/3278
> branch: https://github.com/tarantool/tarantool/compare/gh-3278-quorum-fix
1. Please, put branch and issue links after '---'.
2. The patch still does not work on a case with two nodes,
when one is not available. See the test in the issue comments.
next prev parent reply other threads:[~2018-04-17 18:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 14:07 Konstantin Belyavskiy
2018-04-17 18:09 ` Vladislav Shpilevoy [this message]
2018-04-18 8:07 ` [tarantool-patches] " Konstantin Belyavskiy
2018-04-18 10:33 ` Vladimir Davydov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83d14f21-22bf-da6f-d6bc-7c76a3682c59@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=georgy@tarantool.org \
--cc=k.belyavskiy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov@tarantool.org \
--subject='Re: [tarantool-patches] [PATCH] replication: fix broken cases with quorum=0' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox