Re: [Tarantool-patches] [PATCH 08/14] WIP: refactoring: extract key_def module API functions

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

Hi! Thanks for the answers!

>>> Added libtuple.a to the so called reexport libraries list, because
>>> otherwise the functions from key_def_api compilation unit are not
>>> exported on 1.10 (in the backported patch).
>>>
>>> Part of #5273
>>> ---
>>> diff --git a/src/box/key_def_api.h b/src/box/key_def_api.h
>>> new file mode 100644
>>> index 000000000..5b1c861f5
>>> --- /dev/null
>>> +++ b/src/box/key_def_api.h
>>> @@ -0,0 +1,101 @@
>>> +#ifndef TARANTOOL_BOX_KEY_DEF_API_H_INCLUDED
>>> +#define TARANTOOL_BOX_KEY_DEF_API_H_INCLUDED
>>
>> 2. Lets use '#pragma once'.
> 
>  | Use header guards.
> 
> https://www.tarantool.io/en/doc/latest/dev_guide/c_style_guide/
> 
> Rules are rules.
> 
> You know, I don't like '#pragra once', because it works in non-obvious
> way, had various bugs in the past and may slow down compilation ([1]).
> So I will follow the accepted style.

Then you should use pragma, because they are our rule. I don't believe
you don't remember that discussion. I remember it was assigned to Kirill
to update the docs, since he approved that style change, but it seems he
just didn't.