From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0
Date: Wed, 19 Mar 2025 09:40:58 +0300 [thread overview]
Message-ID: <838068b1-18a3-4a57-9163-836b37394945@tarantool.org> (raw)
In-Reply-To: <Z9mE8wtBUf6mx_Ku@root>
[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]
Nice! LGTM
On 18.03.2025 17:36, Sergey Kaplun wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed your comment and force-pushed the branch.
> See the corresponding run:
> https://github.com/tarantool/luajit/actions/runs/13925861146/job/38970063708#step:4:63
>
> On 12.03.25, Sergey Bronnikov wrote:
>> Please also bump codespell version in .github/workflows/lint.yml.
> Bumped:
>
> ===================================================================
> diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
> index 85e1b646..b0fb83eb 100644
> --- a/.github/workflows/lint.yml
> +++ b/.github/workflows/lint.yml
> @@ -44,7 +44,7 @@ jobs:
> sudo apt -y install cmake ninja-build lua5.1 luarocks
> sudo luarocks install luacheck
> sudo pip3 install flake8==6.1.0
> - sudo pip3 install codespell==2.2.5
> + sudo pip3 install codespell==2.3.0
> # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to
> # limit the number of parallel jobs for build/test step.
> echo CMAKE_BUILD_PARALLEL_LEVEL=$(($(nproc) + 1)) | tee -a $GITHUB_ENV
> ===================================================================
>
>> On 11.03.2025 14:13, Sergey Bronnikov via Tarantool-patches wrote:
> <snipped>
>
[-- Attachment #2: Type: text/html, Size: 2096 bytes --]
next prev parent reply other threads:[~2025-03-19 6:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-10 14:42 Sergey Kaplun via Tarantool-patches
2025-03-11 11:13 ` Sergey Bronnikov via Tarantool-patches
2025-03-12 10:32 ` Sergey Bronnikov via Tarantool-patches
2025-03-18 14:36 ` Sergey Kaplun via Tarantool-patches
2025-03-19 6:40 ` Sergey Bronnikov via Tarantool-patches [this message]
2025-03-26 8:54 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=838068b1-18a3-4a57-9163-836b37394945@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] codehealth: fix warnings for the codespell 2.3.0' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox