Re: [Tarantool-patches] [PATCH] test: disable cases in PUC-Rio tests for debug line hook

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!


thanks for review! Patch has been updated and force-pushed.


On 2/6/23 16:24, Sergey Kaplun wrote:

<snipped>

>>>> module.
>>>             ^ Those tests rely on specific backtrace, which is changed by
>>>     an additional wrapper for `pairs()`.
>> Added to commit message.
> Nit: "tests" should be in plural form in those sentences as far as the
> only one test (the one with `pairs()` usage) is broken after introducing
> `pairs()` wrapper.

Updated in short and long commit message descriptions.


>
>>
>>>>           Patch disables testcases when running under Tarantool.
>>>>
>>>> 1. https://github.com/tarantool/tarantool/issues/2867
>>>> ---
>>>>    test/PUC-Rio-Lua-5.1-tests/db.lua | 4 ++++
>>>>    1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/test/PUC-Rio-Lua-5.1-tests/db.lua b/test/PUC-Rio-Lua-5.1-tests/db.lua
>>>> index b148c2dd..b05075bb 100644
>>>> --- a/test/PUC-Rio-Lua-5.1-tests/db.lua
>>>> +++ b/test/PUC-Rio-Lua-5.1-tests/db.lua
>>>> @@ -169,10 +169,12 @@ test([[for i=1,3 do
>>>>    end
>>>>    ]], {1,2,1,2,1,2,1,3})
>>>>    
>>>> +if not _TARANTOOL then
>>> Minor: It will be nice to add the comment about the wrapper for
>>> `pairs()` in Tarantool here.
>>
>> Added:
>>
>> "Tarantool has a wrapper around builtin function `pairs()`, see see gh-2867.
>> Testcase below relies on a specific backtrace, which is changed by an
>> introduced wrapper for `pairs()`."
> Nit: Please, use `--` comment stile, like elsewhere in this file.
> Multiline comments are used for debug tests and for quoting some chunks
> output.
>
> Friendly reminder: Don't forget to change linedefined below:).


Sure, updated:


@@ -169,11 +169,9 @@ test([[for i=1,3 do
  end
  ]], {1,2,1,2,1,2,1,3})

---[[
-Tarantool has a wrapper around builtin function `pairs()`, see see gh-2867.
-Testcase below relies on a specific backtrace, which is changed by an
-introduced wrapper for `pairs()`.
-]]
+-- Tarantool has a wrapper around builtin function `pairs()`, see see 
gh-2867.
+-- Testcase below relies on a specific backtrace, which is changed by an
+-- introduced wrapper for `pairs()`.
  if not _TARANTOOL then
  test([[for i,v in pairs{'a','b'} do
    a=i..v


<snipped>