From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B7E6270370; Mon, 6 Feb 2023 17:02:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B7E6270370 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1675692145; bh=pwPMmJW6IXvH1RnPL2GxQTi6UKkMCAgRgkvwOobIStA=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=niRvl/IU6NP7sSU6XCc8QPU21LWQDeg3kYYxFqBDIunLH3HWESzu5zFOYbxQg97lP gRD5zTq/mWt8pteqipQauI6GOFf26v30MMbe13oblOcECbp/eUoINIAzUWLUJPH7Qv ITtdP2k1SC4uOVhXOtAOPbt2TzZ0aZrYq8Aj70ZQ= Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [95.163.41.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 74A5470370 for ; Mon, 6 Feb 2023 17:02:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 74A5470370 Received: by smtp38.i.mail.ru with esmtpa (envelope-from ) id 1pP24d-003QPa-Lh; Mon, 06 Feb 2023 17:02:24 +0300 Message-ID: <83645195-e845-1aa3-8ea1-d00a1a91d732@tarantool.org> Date: Mon, 6 Feb 2023 17:01:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Sergey Kaplun References: <821de7208007ffc8f10222761dd264cf0c4a0bb4.1675669159.git.sergeyb@tarantool.org> <75948070-a905-9807-a6d3-44347e80ecc3@tarantool.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D919194CF4FC6604F4B6FC15EC321A30D3704745F162D10F182A05F53808504014548223E28CF8A06ED04806D318B08B3456BDED0EB821E587349C382CCD176E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75B37E0A1C175363BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CB87E27B59CE093D8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D86FA00F3558893809E3BA0FC72E1EF1E1117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC60CDF180582EB8FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520D76C6ED7039589DEF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CB6617C399FBFD4B4040F9FF01DFDA4A84AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C35E208EBACFE9213EBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE760D144E5727D8455731C566533BA786AA5CC5B56E945C8DA X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C53592357E80577325FFD0D2147F659B71565576C2F9FED6627F215B3CDDC365BF92DA266DC91FA01D7E09C32AA3244C0FFE0BB9A8870D5E62BF1CDAC32C05D9C86C126E7119A0FE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj6shc/GkzDh3nexTHxofuKQ== X-Mailru-Sender: 11C2EC085EDE56FAC71737E9F694C0DE4A8EC8C4E5A13C503FF1CA5CE7C451DCCBFEC89150E22AA4645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] test: disable cases in PUC-Rio tests for debug line hook X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Sergey Bronnikov , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! thanks for review! Patch has been updated and force-pushed. On 2/6/23 16:24, Sergey Kaplun wrote: >>>> module. >>> ^ Those tests rely on specific backtrace, which is changed by >>> an additional wrapper for `pairs()`. >> Added to commit message. > Nit: "tests" should be in plural form in those sentences as far as the > only one test (the one with `pairs()` usage) is broken after introducing > `pairs()` wrapper. Updated in short and long commit message descriptions. > >> >>>> Patch disables testcases when running under Tarantool. >>>> >>>> 1. https://github.com/tarantool/tarantool/issues/2867 >>>> --- >>>> test/PUC-Rio-Lua-5.1-tests/db.lua | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/test/PUC-Rio-Lua-5.1-tests/db.lua b/test/PUC-Rio-Lua-5.1-tests/db.lua >>>> index b148c2dd..b05075bb 100644 >>>> --- a/test/PUC-Rio-Lua-5.1-tests/db.lua >>>> +++ b/test/PUC-Rio-Lua-5.1-tests/db.lua >>>> @@ -169,10 +169,12 @@ test([[for i=1,3 do >>>> end >>>> ]], {1,2,1,2,1,2,1,3}) >>>> >>>> +if not _TARANTOOL then >>> Minor: It will be nice to add the comment about the wrapper for >>> `pairs()` in Tarantool here. >> >> Added: >> >> "Tarantool has a wrapper around builtin function `pairs()`, see see gh-2867. >> Testcase below relies on a specific backtrace, which is changed by an >> introduced wrapper for `pairs()`." > Nit: Please, use `--` comment stile, like elsewhere in this file. > Multiline comments are used for debug tests and for quoting some chunks > output. > > Friendly reminder: Don't forget to change linedefined below:). Sure, updated: @@ -169,11 +169,9 @@ test([[for i=1,3 do  end  ]], {1,2,1,2,1,2,1,3}) ---[[ -Tarantool has a wrapper around builtin function `pairs()`, see see gh-2867. -Testcase below relies on a specific backtrace, which is changed by an -introduced wrapper for `pairs()`. -]] +-- Tarantool has a wrapper around builtin function `pairs()`, see see gh-2867. +-- Testcase below relies on a specific backtrace, which is changed by an +-- introduced wrapper for `pairs()`.  if not _TARANTOOL then  test([[for i,v in pairs{'a','b'} do    a=i..v