From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
Subject: Re: [PATCH 2/2] info: remove false comments from src/info.h
Date: Tue, 4 Dec 2018 12:11:09 +0300 [thread overview]
Message-ID: <82f8dcde-7dec-9509-d499-9bb25d5348de@tarantool.org> (raw)
In-Reply-To: <20181204090224.clqmdwibpqpallva@esperanza>
On 04/12/2018 12:02, Vladimir Davydov wrote:
> On Tue, Dec 04, 2018 at 12:47:06AM +0300, Vladislav Shpilevoy wrote:
>> ---
>> src/info.h | 7 -------
>> 1 file changed, 7 deletions(-)
>>
>> diff --git a/src/info.h b/src/info.h
>> index 0198c31d4..cafa425e9 100644
>> --- a/src/info.h
>> +++ b/src/info.h
>> @@ -103,7 +103,6 @@ struct info_handler {
>> /**
>> * Starts a new document and creates root-level associative array.
>> * @param info box.info() adapter.
>> - * @throws C++ exception on OOM, see info.h comments.
>> * @pre must be called once before any other functions.
>
> These comments are valid - info handler does throw an exception on OOM,
> and there's a comment in src/info.h mentioning that. So I dropped this
> patch.
>
Sorry, I though you forgot about it and pushed it by myself.
Also, it does not throw C++ exceptions, even on OOM.
next prev parent reply other threads:[~2018-12-04 9:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 21:47 [PATCH 0/2] Move info to src/ for SWIM Vladislav Shpilevoy
2018-12-03 21:47 ` [PATCH 1/2] box: move info_handler interface into src/info Vladislav Shpilevoy
2018-12-04 8:59 ` Vladimir Davydov
2018-12-03 21:47 ` [PATCH 2/2] info: remove false comments from src/info.h Vladislav Shpilevoy
2018-12-04 9:02 ` Vladimir Davydov
2018-12-04 9:11 ` Vladislav Shpilevoy [this message]
2018-12-04 9:46 ` Vladimir Davydov
2018-12-04 10:17 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82f8dcde-7dec-9509-d499-9bb25d5348de@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=tarantool-patches@freelists.org \
--cc=vdavydov.dev@gmail.com \
--subject='Re: [PATCH 2/2] info: remove false comments from src/info.h' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox