[tarantool-patches] Re: [PATCH 2/2] test: add output filtering feature

[roman.habibov1@yandex.ru]

Hi! Thanks for review/

>
> On Fri, Sep 21, 2018 at 03:54:42AM +0300, roman.habibov1@yandex.ru wrote:
>>  Add output filtering feature for engine/savepoint.test.
>>
>>  Part of #3518.
>>  ---
>>  commit b8be4c51e29110f459bd58dba51d6546cd9da25b
>>  Author: Roman Khabibov <roman.habibov1@yandex.ru>
>>  Date: Fri Sep 21 03:28:04 2018 +0300
>>
>>      test: add output filtering feature
>
> Please, describe the change in less abstract manner, like 'test: filter
> line numbers from engine/savepoint'. Now the description looks like you
> are implement this feature from scratch.
Done.

commit a3110d84a171ab886612fe89d2094e2e3bd30f7f
Author: Roman Khabibov <roman.habibov1@yandex.ru>
Date:   Fri Sep 21 03:28:04 2018 +0300

    test: filter line numbers from engine/savepoint
    
    Part of #3518

diff --git a/test/engine/savepoint.result b/test/engine/savepoint.result
index a62a2e1..b3a918d 100644
--- a/test/engine/savepoint.result
+++ b/test/engine/savepoint.result
@@ -4,6 +4,10 @@ env = require('test_run')
 test_run = env.new()
 ---
 ...
+test_run:cmd("push filter '(.builtin/.*.lua):[0-9]+' to '\\1'")
+---
+- true
+...
 -- gh-2025 box.savepoint
 s1 = nil
 ---
@@ -14,7 +18,7 @@ s1 = box.savepoint()
 ...
 box.rollback_to_savepoint(s1)
 ---
-- error: 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
+- error: 'builtin/box/schema.lua: Usage: box.rollback_to_savepoint(savepoint)'
 ...
 box.begin() s1 = box.savepoint()
 ---
@@ -323,27 +327,27 @@ test_run:cmd("setopt delimiter ''");
 ok1, errmsg1
 ---
 - false
-- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
+- 'builtin/box/schema.lua: Usage: box.rollback_to_savepoint(savepoint)'
 ...
 ok2, errmsg2
 ---
 - false
-- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
+- 'builtin/box/schema.lua: Usage: box.rollback_to_savepoint(savepoint)'
 ...
 ok3, errmsg3
 ---
 - false
-- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
+- 'builtin/box/schema.lua: Usage: box.rollback_to_savepoint(savepoint)'
 ...
 ok4, errmsg4
 ---
 - false
-- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
+- 'builtin/box/schema.lua: Usage: box.rollback_to_savepoint(savepoint)'
 ...
 ok5, errmsg5
 ---
 - false
-- 'builtin/box/schema.lua:340: Usage: box.rollback_to_savepoint(savepoint)'
+- 'builtin/box/schema.lua: Usage: box.rollback_to_savepoint(savepoint)'
 ...
 s:select{}
 ---
diff --git a/test/engine/savepoint.test.lua b/test/engine/savepoint.test.lua
index de8f297..186ef85 100644
--- a/test/engine/savepoint.test.lua
+++ b/test/engine/savepoint.test.lua
@@ -1,5 +1,6 @@
 env = require('test_run')
 test_run = env.new()
+test_run:cmd("push filter '(.builtin/.*.lua):[0-9]+' to '\\1'")
 
 -- gh-2025 box.savepoint