Tarantool development patches archive
 help / color / mirror / Atom feed
From: Georgy Kirichenko <georgy@tarantool.org>
To: tarantool-patches@freelists.org
Cc: Georgy Kirichenko <georgy@tarantool.org>
Subject: [tarantool-patches] [PATCH 7/7] Refactoring: get rid of on_close_log
Date: Tue, 13 Aug 2019 09:27:45 +0300	[thread overview]
Message-ID: <81bbe756adc6521928214bb5cf80e40e0bb6be38.1565676868.git.georgy@tarantool.org> (raw)
In-Reply-To: <cover.1565676868.git.georgy@tarantool.org>

We do not use this one
---
 src/box/recovery.cc | 3 ---
 src/box/recovery.h  | 2 --
 2 files changed, 5 deletions(-)

diff --git a/src/box/recovery.cc b/src/box/recovery.cc
index 45c4f6820..fa0426726 100644
--- a/src/box/recovery.cc
+++ b/src/box/recovery.cc
@@ -111,7 +111,6 @@ recovery_new(const char *wal_dirname, bool force_recovery,
 	xdir_check_xc(&r->wal_dir);
 
 	r->watcher = NULL;
-	rlist_create(&r->on_close_log);
 
 	guard.is_active = false;
 	return r;
@@ -151,7 +150,6 @@ recovery_close_log(struct recovery *r)
 			 r->cursor.name);
 	}
 	xlog_cursor_close(&r->cursor, false);
-	trigger_run_xc(&r->on_close_log, NULL);
 }
 
 static void
@@ -213,7 +211,6 @@ recovery_delete(struct recovery *r)
 {
 	recovery_stop_local(r);
 
-	trigger_destroy(&r->on_close_log);
 	xdir_destroy(&r->wal_dir);
 	if (xlog_cursor_is_open(&r->cursor)) {
 		/*
diff --git a/src/box/recovery.h b/src/box/recovery.h
index 2a03cfc2f..1026507c2 100644
--- a/src/box/recovery.h
+++ b/src/box/recovery.h
@@ -56,8 +56,6 @@ struct recovery {
 	 * them locally.
 	 */
 	struct fiber *watcher;
-	/** List of triggers invoked when the current WAL is closed. */
-	struct rlist on_close_log;
 };
 
 struct recovery *
-- 
2.22.0

  parent reply	other threads:[~2019-08-13  6:27 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  6:27 [tarantool-patches] [PATCH 0/7] Replication: In-memory replication Georgy Kirichenko
2019-08-13  6:27 ` [tarantool-patches] [PATCH 1/7] Refactoring: wal writer fiber and queue Georgy Kirichenko
2019-08-16 13:53   ` [tarantool-patches] " Konstantin Osipov
2019-08-20 10:57     ` Георгий Кириченко
2019-08-21 10:18   ` [tarantool-patches] " Vladimir Davydov
2019-08-13  6:27 ` [tarantool-patches] [PATCH 2/7] Refactoring: Track wal files using gc state Georgy Kirichenko
2019-08-21 10:44   ` Vladimir Davydov
2019-08-13  6:27 ` [tarantool-patches] [PATCH 3/7] Replication: Relay does not rely on xlog boundaries Georgy Kirichenko
2019-08-21 11:35   ` Vladimir Davydov
2019-08-13  6:27 ` [tarantool-patches] [PATCH 4/7] Replication: wal memory buffer Georgy Kirichenko
2019-08-21 11:57   ` Vladimir Davydov
2019-08-13  6:27 ` [tarantool-patches] [PATCH 5/7] Replication: in memory replication Georgy Kirichenko
2019-08-21 13:52   ` Vladimir Davydov
2019-08-13  6:27 ` [tarantool-patches] [PATCH 6/7] Refactoring: remove wal_watcher routines Georgy Kirichenko
2019-08-21 13:52   ` Vladimir Davydov
2019-08-13  6:27 ` Georgy Kirichenko [this message]
2019-08-21 13:52   ` [tarantool-patches] [PATCH 7/7] Refactoring: get rid of on_close_log Vladimir Davydov
2019-08-16 13:47 ` [tarantool-patches] Re: [PATCH 0/7] Replication: In-memory replication Konstantin Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81bbe756adc6521928214bb5cf80e40e0bb6be38.1565676868.git.georgy@tarantool.org \
    --to=georgy@tarantool.org \
    --cc=tarantool-patches@freelists.org \
    --subject='Re: [tarantool-patches] [PATCH 7/7] Refactoring: get rid of on_close_log' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox