From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Konstantin Osipov <kostja.osipov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row
Date: Fri, 29 May 2020 15:15:52 +0300 [thread overview]
Message-ID: <8144a701-bd4a-8ec5-604e-0f3106a3b373@tarantool.org> (raw)
In-Reply-To: <20200529115154.GA144179@atlas>
29.05.2020 14:51, Konstantin Osipov пишет:
> * Serge Petrenko <sergepetrenko@tarantool.org> [20/05/29 14:44]:
>> I understand this is a crutch, but it's the best solution I could come
>> up with. Appending dummy NOPs will increase instance LSN by one,
>> which also looks ugly. The correct solution is, indeed, to collect a tx
>> in relay and mangle with it in any means we need before sending, however,
>> I faced some problems with this approach. See more in v1 of this patchset
>> (letter [PATCH 2/2] replication: make relay send txs in batches).
>>
> What were the issues changing xstream api apart from never trying?
No issues, it's just a big change. At least it looks like there're no
issues until I try the approach.
>
>
--
Serge Petrenko
next prev parent reply other threads:[~2020-05-29 12:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 10:58 [Tarantool-patches] [PATCH v2 0/2] fix replication tx boundaries after local space rework Serge Petrenko
2020-05-25 10:58 ` [Tarantool-patches] [PATCH v2 1/2] wal: fix tx boundaries Serge Petrenko
2020-05-28 22:53 ` Vladislav Shpilevoy
2020-05-29 11:09 ` Serge Petrenko
2020-05-25 10:58 ` [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row Serge Petrenko
2020-05-25 15:13 ` Cyrill Gorcunov
2020-05-25 16:34 ` Konstantin Osipov
2020-05-25 18:35 ` Cyrill Gorcunov
2020-05-25 20:42 ` Konstantin Osipov
2020-05-26 9:41 ` Serge Petrenko
2020-05-26 11:41 ` Konstantin Osipov
2020-05-26 12:08 ` Serge Petrenko
2020-05-28 22:54 ` Vladislav Shpilevoy
2020-05-29 8:13 ` Konstantin Osipov
2020-05-29 11:42 ` Serge Petrenko
2020-05-29 11:51 ` Konstantin Osipov
2020-05-29 12:07 ` Cyrill Gorcunov
2020-05-29 12:07 ` Cyrill Gorcunov
2020-05-29 12:15 ` Serge Petrenko [this message]
2020-05-29 13:44 ` Konstantin Osipov
2020-05-29 15:55 ` Serge Petrenko
2020-06-01 13:40 ` Vladislav Shpilevoy
2020-06-01 16:02 ` Sergey Ostanevich
2020-06-01 17:06 ` Vladislav Shpilevoy
2020-05-28 22:53 ` [Tarantool-patches] [PATCH v2 0/2] fix replication tx boundaries after local space rework Vladislav Shpilevoy
2020-05-29 11:03 ` Serge Petrenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8144a701-bd4a-8ec5-604e-0f3106a3b373@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=kostja.osipov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 2/2] wal: reorder tx rows so that a tx ends on a global row' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox