From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: "n.pettik" <korablev@tarantool.org>,
tarantool-patches@freelists.org,
Kirill Yukhin <kyukhin@tarantool.org>
Subject: [tarantool-patches] Re: [PATCH 5/5] sql: introduce VARBINARY column type
Date: Tue, 30 Jul 2019 21:52:23 +0200 [thread overview]
Message-ID: <80b10469-4c03-f138-fec7-b7a31857cfb8@tarantool.org> (raw)
In-Reply-To: <a6fb66a6-452d-7594-610c-3430b6448c66@tarantool.org>
Oh, but wait. Travis is fully red:
https://travis-ci.org/tarantool/tarantool/builds/565497371?utm_source=github_status&utm_medium=notification
Looks like you forgot to update plan in sql-tap/func.test.lua.
On 30/07/2019 21:41, Vladislav Shpilevoy wrote:
> Hi! Thanks for the fixes!
>
> LGTM.
>
>>>>> 3. BLOB keyword is reserved, but also it is used in parse.y:980.
>>>>> Should not it be deleted from all the rules, and be just
>>>>> reserved?
>>>>
>>>> It’s rule for declaring blob (aka binary string) literals.
>>>> I can rename it, but TBO it looks OK to me.
>>>
>>> Could you please provide an example, how to use BLOB keyword to
>>> declare a literal? I can't find any test, using BLOB in a query
>>> string for anything.
>>
>> I meant that it’s not the rule that allows BLOB keyword but
>> the rule to process X’…’ literals. When string is processed by
>> lexer (tokenize.c) its token type is assigned to TK_BLOB.
>
> Ahh, I got it now. BLOB(X) is not a 'BLOB' keyword, it is rather
> like a rule 'BLOB := x...'. Then of course it is ok, nothing to
> do here.
>
next prev parent reply other threads:[~2019-07-30 19:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 11:42 [tarantool-patches] [PATCH 0/5] Introduce VARBINARY in SQL Nikita Pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 1/5] sql: always erase numeric flag after stringifying Nikita Pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 2/5] sql: fix resulting type calculation for CASE-WHEN stmt Nikita Pettik
2019-07-25 22:12 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <a061e845-eeb1-00d1-9141-3b9bb87768f5@tarantool.org>
2019-07-28 23:56 ` n.pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 3/5] sql: use 'varbinary' as a name of type instead of 'blob' Nikita Pettik
2019-07-25 22:11 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <2e655514-0fec-8baf-20a8-d49e5586b047@tarantool.org>
2019-07-28 23:56 ` n.pettik
2019-07-29 21:03 ` Vladislav Shpilevoy
2019-07-30 13:43 ` n.pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 4/5] sql: make built-ins raise errors for varbin args Nikita Pettik
2019-07-25 22:11 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <05d15035-2552-1f05-b7ce-facfbbc3a520@tarantool.org>
2019-07-28 23:59 ` n.pettik
2019-07-24 11:42 ` [tarantool-patches] [PATCH 5/5] sql: introduce VARBINARY column type Nikita Pettik
2019-07-25 22:12 ` [tarantool-patches] " Vladislav Shpilevoy
[not found] ` <49a188eb-dafe-44e7-a0fd-e9244b68e721@tarantool.org>
2019-07-29 0:03 ` n.pettik
2019-07-29 20:55 ` Vladislav Shpilevoy
2019-07-30 13:44 ` n.pettik
2019-07-30 19:41 ` Vladislav Shpilevoy
2019-07-30 19:52 ` Vladislav Shpilevoy [this message]
2019-07-31 14:51 ` n.pettik
2019-08-01 8:42 ` [tarantool-patches] Re: [PATCH 0/5] Introduce VARBINARY in SQL Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80b10469-4c03-f138-fec7-b7a31857cfb8@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=korablev@tarantool.org \
--cc=kyukhin@tarantool.org \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH 5/5] sql: introduce VARBINARY column type' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox