From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 2/6] journal: bind asynchronous write completion to an entry
Date: Mon, 27 Jul 2020 22:40:47 +0200 [thread overview]
Message-ID: <806a1209-6838-778a-43ca-fce81d32ae71@tarantool.org> (raw)
In-Reply-To: <20200727140650.447750-3-gorcunov@gmail.com>
Hi! Thanks for the patch!
> diff --git a/src/box/journal.h b/src/box/journal.h
> index 9049a2ce0..759eea1da 100644
> --- a/src/box/journal.h
> +++ b/src/box/journal.h
> @@ -39,8 +39,11 @@
> extern "C" {
> #endif /* defined(__cplusplus) */
>
> +struct journal_entry;
1. You removed this declaration in the previous commit. I guess you
don't need the latter now.
> struct xrow_header;
>
> +typedef void (*journal_write_async_cb_t)(struct journal_entry *entry);
2. Better replace _cb_t with _f. Or with just _t. Look at key_def.h and
xrow_update_field.h for examples.
> +
> /**
> * An entry for an abstract journal.
next prev parent reply other threads:[~2020-07-27 20:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-27 14:06 [Tarantool-patches] [PATCH v3 0/6] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov
2020-07-27 14:06 ` [Tarantool-patches] [PATCH v3 1/6] journal: drop redundant declaration Cyrill Gorcunov
2020-07-27 14:06 ` [Tarantool-patches] [PATCH v3 2/6] journal: bind asynchronous write completion to an entry Cyrill Gorcunov
2020-07-27 20:40 ` Vladislav Shpilevoy [this message]
2020-07-27 21:37 ` Cyrill Gorcunov
2020-07-27 14:06 ` [Tarantool-patches] [PATCH v3 3/6] journal: add journal_entry_create helper Cyrill Gorcunov
2020-07-27 14:06 ` [Tarantool-patches] [PATCH v3 4/6] qsync: provide a binary form of syncro entries Cyrill Gorcunov
2020-07-27 14:06 ` [Tarantool-patches] [PATCH v3 5/6] qsync: implement direct write of CONFIRM/ROLLBACK into a journal Cyrill Gorcunov
2020-07-27 20:41 ` Vladislav Shpilevoy
2020-07-27 21:39 ` Cyrill Gorcunov
2020-07-27 14:06 ` [Tarantool-patches] [PATCH v3 6/6] qsync: drop no longer used encoding helpers Cyrill Gorcunov
2020-07-27 14:12 ` [Tarantool-patches] [PATCH v3 0/6] qsync: write CONFIRM/ROLLBACK without txn engine Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=806a1209-6838-778a-43ca-fce81d32ae71@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 2/6] journal: bind asynchronous write completion to an entry' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox