From: Leonid Vasiliev <lvasiliev@tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org>, tarantool-patches@dev.tarantool.org Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] refactoring: drop excess 16Kb bss buffer Date: Thu, 23 Jan 2020 13:51:49 +0300 [thread overview] Message-ID: <7fcea3b9-2e99-a52f-6997-51be73edec6e@tarantool.org> (raw) In-Reply-To: <20200123084445.7452-1-skaplun@tarantool.org> On 1/23/20 11:44 AM, Sergey Kaplun wrote: > We already have 12Kb thread-safe static buffer > in `lib/small/small/static.h`, that can be used instead of 16Kb > bss buffer in `src/lib/core/backtrace.cc` for backtrace payload. > > Closes #4650 > --- > > branch: https://github.com/tarantool/tarantool/tree/skaplun/drop-bss-buff > issue: https://github.com/tarantool/tarantool/issues/4650 > > src/lib/core/backtrace.cc | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc > index 77f77b05c..c70576b53 100644 > --- a/src/lib/core/backtrace.cc > +++ b/src/lib/core/backtrace.cc > @@ -33,6 +33,7 @@ > > #include <stdlib.h> > #include <stdio.h> > +#include <assert.h> > > #include <cxxabi.h> > > @@ -47,6 +48,7 @@ > #include <libunwind.h> > > #include "small/region.h" > +#include "small/static.h" > /* > * We use a global static buffer because it is too late to do any > * allocation when we are printing backtrace and fiber stack is May be to change the comment or relocate it? > @@ -55,8 +57,6 @@ > > #define BACKTRACE_NAME_MAX 200 > > -static char backtrace_buf[4096 * 4]; > - > static __thread struct region cache_region; > static __thread struct mh_i64ptr_t *proc_cache = NULL; > > @@ -140,8 +140,10 @@ backtrace() > unw_getcontext(&unw_context); > unw_cursor_t unw_cur; > unw_init_local(&unw_cur, &unw_context); > + char *backtrace_buf = (char *)static_alloc(SMALL_STATIC_SIZE); > + assert(backtrace_buf); Do a check on NULL for Release? > char *p = backtrace_buf; > - char *end = p + sizeof(backtrace_buf) - 1; > + char *end = p + SMALL_STATIC_SIZE - 1; > int unw_status; > *p = '\0'; > while ((unw_status = unw_step(&unw_cur)) > 0) { >
next prev parent reply other threads:[~2020-01-23 10:51 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-23 8:44 Sergey Kaplun 2020-01-23 10:51 ` Leonid Vasiliev [this message] 2020-01-23 22:04 ` Vladislav Shpilevoy 2020-01-29 13:36 ` Sergey Ostanevich 2020-01-30 5:46 ` Leonid Vasiliev 2020-01-31 22:30 ` Sergey Kaplun 2020-02-03 6:51 ` Leonid Vasiliev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7fcea3b9-2e99-a52f-6997-51be73edec6e@tarantool.org \ --to=lvasiliev@tarantool.org \ --cc=skaplun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v2] refactoring: drop excess 16Kb bss buffer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox