From: Vladimir Davydov <vdavydov.dev@gmail.com> To: kostja@tarantool.org Cc: tarantool-patches@freelists.org Subject: [RFC PATCH 19/23] vinyl: rename some members of vy_scheduler and vy_task struct Date: Sun, 8 Jul 2018 19:48:50 +0300 [thread overview] Message-ID: <7f2c4b5b54f5d55af4363ff02c82d6d43e8f0e03.1531065648.git.vdavydov.dev@gmail.com> (raw) In-Reply-To: <cover.1531065648.git.vdavydov.dev@gmail.com> In-Reply-To: <cover.1531065648.git.vdavydov.dev@gmail.com> I'm planning to add some new members and remove some old members from those structs. For this to play nicely, let's do some renames: vy_scheduler::workers_available => idle_worker_count vy_scheduler::input_queue => pending_tasks vy_scheduler::output_queue => processed_tasks vy_task::link => in_pending, in_processed --- src/box/vy_scheduler.c | 50 ++++++++++++++++++++++++++------------------------ src/box/vy_scheduler.h | 10 +++++----- 2 files changed, 31 insertions(+), 29 deletions(-) diff --git a/src/box/vy_scheduler.c b/src/box/vy_scheduler.c index 5684f4d4..4d84f9bc 100644 --- a/src/box/vy_scheduler.c +++ b/src/box/vy_scheduler.c @@ -120,17 +120,16 @@ struct vy_task { */ struct vy_slice *first_slice, *last_slice; /** - * Link in the list of pending or processed tasks. - * See vy_scheduler::input_queue, output_queue. - */ - struct stailq_entry link; - /** * Index options may be modified while a task is in * progress so we save them here to safely access them * from another thread. */ double bloom_fpr; int64_t page_size; + /** Link in vy_scheduler::pending_tasks. */ + struct stailq_entry in_pending; + /** Link in vy_scheduler::processed_tasks. */ + struct stailq_entry in_processed; }; /** @@ -259,7 +258,7 @@ vy_scheduler_start_workers(struct vy_scheduler *scheduler) assert(scheduler->worker_pool_size >= 2); scheduler->is_worker_pool_running = true; - scheduler->workers_available = scheduler->worker_pool_size; + scheduler->idle_worker_count = scheduler->worker_pool_size; scheduler->worker_pool = calloc(scheduler->worker_pool_size, sizeof(struct cord)); if (scheduler->worker_pool == NULL) @@ -318,8 +317,8 @@ vy_scheduler_create(struct vy_scheduler *scheduler, int write_threads, scheduler->worker_pool_size = write_threads; mempool_create(&scheduler->task_pool, cord_slab_cache(), sizeof(struct vy_task)); - stailq_create(&scheduler->input_queue); - stailq_create(&scheduler->output_queue); + stailq_create(&scheduler->pending_tasks); + stailq_create(&scheduler->processed_tasks); tt_pthread_cond_init(&scheduler->worker_cond, NULL); tt_pthread_mutex_init(&scheduler->mutex, NULL); @@ -1422,7 +1421,7 @@ vy_schedule(struct vy_scheduler *scheduler, struct vy_task **ptask) if (*ptask != NULL) return 0; - if (scheduler->workers_available <= 1) { + if (scheduler->idle_worker_count <= 1) { /* * If all worker threads are busy doing compaction * when we run out of quota, ongoing transactions will @@ -1501,26 +1500,27 @@ vy_scheduler_f(va_list va) vy_scheduler_start_workers(scheduler); while (scheduler->scheduler_fiber != NULL) { - struct stailq output_queue; + struct stailq processed_tasks; struct vy_task *task, *next; int tasks_failed = 0, tasks_done = 0; bool was_empty; /* Get the list of processed tasks. */ - stailq_create(&output_queue); + stailq_create(&processed_tasks); tt_pthread_mutex_lock(&scheduler->mutex); - stailq_concat(&output_queue, &scheduler->output_queue); + stailq_concat(&processed_tasks, &scheduler->processed_tasks); tt_pthread_mutex_unlock(&scheduler->mutex); /* Complete and delete all processed tasks. */ - stailq_foreach_entry_safe(task, next, &output_queue, link) { + stailq_foreach_entry_safe(task, next, &processed_tasks, + in_processed) { if (vy_task_complete(task) != 0) tasks_failed++; else tasks_done++; vy_task_delete(task); - scheduler->workers_available++; - assert(scheduler->workers_available <= + scheduler->idle_worker_count++; + assert(scheduler->idle_worker_count <= scheduler->worker_pool_size); } /* @@ -1534,7 +1534,7 @@ vy_scheduler_f(va_list va) * opens a time window for a worker to submit * a processed task and wake up the scheduler * (via scheduler_async). Hence we should go - * and recheck the output_queue in order not + * and recheck the processed_tasks in order not * to lose a wakeup event and hang for good. */ continue; @@ -1543,7 +1543,7 @@ vy_scheduler_f(va_list va) if (tasks_failed > 0) goto error; /* All worker threads are busy. */ - if (scheduler->workers_available == 0) + if (scheduler->idle_worker_count == 0) goto wait; /* Get a task to schedule. */ if (vy_schedule(scheduler, &task) != 0) @@ -1554,13 +1554,14 @@ vy_scheduler_f(va_list va) /* Queue the task and notify workers if necessary. */ tt_pthread_mutex_lock(&scheduler->mutex); - was_empty = stailq_empty(&scheduler->input_queue); - stailq_add_tail_entry(&scheduler->input_queue, task, link); + was_empty = stailq_empty(&scheduler->pending_tasks); + stailq_add_tail_entry(&scheduler->pending_tasks, + task, in_pending); if (was_empty) tt_pthread_cond_signal(&scheduler->worker_cond); tt_pthread_mutex_unlock(&scheduler->mutex); - scheduler->workers_available--; + scheduler->idle_worker_count--; fiber_reschedule(); continue; error: @@ -1605,7 +1606,7 @@ vy_worker_f(void *arg) tt_pthread_mutex_lock(&scheduler->mutex); while (scheduler->is_worker_pool_running) { /* Wait for a task */ - if (stailq_empty(&scheduler->input_queue)) { + if (stailq_empty(&scheduler->pending_tasks)) { /* Wake scheduler up if there are no more tasks */ ev_async_send(scheduler->scheduler_loop, &scheduler->scheduler_async); @@ -1613,8 +1614,8 @@ vy_worker_f(void *arg) &scheduler->mutex); continue; } - task = stailq_shift_entry(&scheduler->input_queue, - struct vy_task, link); + task = stailq_shift_entry(&scheduler->pending_tasks, + struct vy_task, in_pending); tt_pthread_mutex_unlock(&scheduler->mutex); assert(task != NULL); @@ -1628,7 +1629,8 @@ vy_worker_f(void *arg) /* Return processed task to scheduler */ tt_pthread_mutex_lock(&scheduler->mutex); - stailq_add_tail_entry(&scheduler->output_queue, task, link); + stailq_add_tail_entry(&scheduler->processed_tasks, + task, in_processed); } tt_pthread_mutex_unlock(&scheduler->mutex); return NULL; diff --git a/src/box/vy_scheduler.h b/src/box/vy_scheduler.h index 777756c0..284f666e 100644 --- a/src/box/vy_scheduler.h +++ b/src/box/vy_scheduler.h @@ -77,13 +77,13 @@ struct vy_scheduler { /** Total number of worker threads. */ int worker_pool_size; /** Number worker threads that are currently idle. */ - int workers_available; + int idle_worker_count; /** Memory pool used for allocating vy_task objects. */ struct mempool task_pool; - /** Queue of pending tasks, linked by vy_task::link. */ - struct stailq input_queue; - /** Queue of processed tasks, linked by vy_task::link. */ - struct stailq output_queue; + /** Queue of pending tasks, linked by vy_task::in_pending. */ + struct stailq pending_tasks; + /** Queue of processed tasks, linked by vy_task::in_processed. */ + struct stailq processed_tasks; /** * Signaled to wake up a worker when there is * a pending task in the input queue. Also used -- 2.11.0
next prev parent reply other threads:[~2018-07-08 16:48 UTC|newest] Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-08 16:48 [RFC PATCH 02/23] vinyl: always get full tuple from pk after reading from secondary index Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 00/23] vinyl: eliminate read on REPLACE/DELETE Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 01/23] vinyl: do not turn REPLACE into INSERT when processing DML request Vladimir Davydov 2018-07-10 12:15 ` Konstantin Osipov 2018-07-10 12:19 ` Vladimir Davydov 2018-07-10 18:39 ` Konstantin Osipov 2018-07-11 7:57 ` Vladimir Davydov 2018-07-11 10:25 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 03/23] vinyl: use vy_mem_iterator for point lookup Vladimir Davydov 2018-07-17 10:14 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 04/23] vinyl: make point lookup always return the latest tuple version Vladimir Davydov 2018-07-10 16:19 ` Konstantin Osipov 2018-07-10 16:43 ` Vladimir Davydov 2018-07-11 16:33 ` Vladimir Davydov 2018-07-31 19:17 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 05/23] vinyl: fold vy_replace_one and vy_replace_impl Vladimir Davydov 2018-07-31 20:28 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 06/23] vinyl: fold vy_delete_impl Vladimir Davydov 2018-07-31 20:28 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 07/23] vinyl: refactor unique check Vladimir Davydov 2018-07-31 20:28 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 08/23] vinyl: check key uniqueness before modifying tx write set Vladimir Davydov 2018-07-31 20:34 ` Konstantin Osipov 2018-08-01 10:42 ` Vladimir Davydov 2018-08-09 20:26 ` Konstantin Osipov 2018-08-10 8:26 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 09/23] vinyl: remove env argument of vy_check_is_unique_{primary,secondary} Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 10/23] vinyl: store full tuples in secondary index cache Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 11/23] xrow: allow to store flags in DML requests Vladimir Davydov 2018-07-31 20:36 ` Konstantin Osipov 2018-08-01 14:10 ` Vladimir Davydov 2018-08-17 13:34 ` Vladimir Davydov 2018-08-17 13:34 ` [PATCH 1/2] xrow: allow to store tuple metadata in request Vladimir Davydov 2018-08-17 13:34 ` [PATCH 2/2] vinyl: introduce statement flags Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 12/23] vinyl: do not pass region explicitly to write iterator functions Vladimir Davydov 2018-07-17 10:16 ` Vladimir Davydov 2018-07-31 20:38 ` Konstantin Osipov 2018-08-01 14:14 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 13/23] vinyl: fix potential use-after-free in vy_read_view_merge Vladimir Davydov 2018-07-17 10:16 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 14/23] test: unit/vy_write_iterator: minor refactoring Vladimir Davydov 2018-07-17 10:17 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 15/23] vinyl: teach write iterator to return overwritten tuples Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 16/23] vinyl: allow to skip certain statements on read Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 17/23] vinyl: do not free pending tasks on shutdown Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 18/23] vinyl: store pointer to scheduler in struct vy_task Vladimir Davydov 2018-07-31 20:39 ` Konstantin Osipov 2018-07-08 16:48 ` Vladimir Davydov [this message] 2018-07-31 20:40 ` [RFC PATCH 19/23] vinyl: rename some members of vy_scheduler and vy_task struct Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 20/23] vinyl: use cbus for communication between scheduler and worker threads Vladimir Davydov 2018-07-31 20:43 ` Konstantin Osipov 2018-08-01 14:26 ` Vladimir Davydov 2018-07-08 16:48 ` [RFC PATCH 21/23] vinyl: zap vy_scheduler::is_worker_pool_running Vladimir Davydov 2018-07-31 20:43 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 22/23] vinyl: rename vy_task::status to is_failed Vladimir Davydov 2018-07-31 20:44 ` Konstantin Osipov 2018-07-08 16:48 ` [RFC PATCH 23/23] vinyl: eliminate read on REPLACE/DELETE Vladimir Davydov 2018-07-13 10:53 ` Vladimir Davydov 2018-07-13 10:53 ` [PATCH 1/3] stailq: add stailq_insert function Vladimir Davydov 2018-07-15 7:02 ` Konstantin Osipov 2018-07-15 13:17 ` Vladimir Davydov 2018-07-15 18:40 ` Konstantin Osipov 2018-07-17 10:18 ` Vladimir Davydov 2018-07-13 10:53 ` [PATCH 2/3] vinyl: link all indexes of the same space Vladimir Davydov 2018-07-13 10:53 ` [PATCH 3/3] vinyl: generate deferred DELETEs on tx commit Vladimir Davydov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7f2c4b5b54f5d55af4363ff02c82d6d43e8f0e03.1531065648.git.vdavydov.dev@gmail.com \ --to=vdavydov.dev@gmail.com \ --cc=kostja@tarantool.org \ --cc=tarantool-patches@freelists.org \ --subject='Re: [RFC PATCH 19/23] vinyl: rename some members of vy_scheduler and vy_task struct' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox