Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: tarantool-patches@dev.tarantool.org,
	Sergey Kaplun <skaplun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Subject: [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash
Date: Fri,  6 Dec 2024 10:06:11 +0300	[thread overview]
Message-ID: <7f150753add9e09fd2285ccaa7c70e6a6dc949ab.1733468484.git.sergeyb@tarantool.org> (raw)
In-Reply-To: <cover.1733468484.git.sergeyb@tarantool.org>

From: Sergey Bronnikov <sergeyb@tarantool.org>

- fix a typo in a comment
- replace `skip_all()` with `skip()` because it is strange
  to skip overall test group inside a testcase.
---
 test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
index cf1d815a..a8de3358 100644
--- a/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
+++ b/test/tarantool-c-tests/gh-8594-sysprof-ffunc-crash.test.c
@@ -17,7 +17,7 @@
 
 /*
  * XXX: The test is *very* Linux/x86_64 specific. Fortunately, so
- * does the sampling profiler. <lj_arch.> is needed for LUAJIT_OS
+ * does the sampling profiler. <lj_arch.h> is needed for LUAJIT_OS
  * and LUAJIT_TARGET.
  */
 #include "lj_arch.h"
@@ -270,7 +270,7 @@ static int test_tostring_call(void *ctx)
 
 static int test_tostring_call(void *ctx)
 {
-	return skip_all("sysprof is implemented for Linux/x86_64 only");
+	return skip("sysprof is implemented for Linux/x86_64 only");
 }
 
 #endif /* LUAJIT_OS == LUAJIT_OS_LINUX && LUAJIT_TARGET == LUAJIT_ARCH_X64 */
-- 
2.34.1


  reply	other threads:[~2024-12-06  7:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-06  7:05 [Tarantool-patches] [PATCH luajit 0/2] Respect LUAJIT_DISABLE_SYSPROF in sysprof tests Sergey Bronnikov via Tarantool-patches
2024-12-06  7:06 ` Sergey Bronnikov via Tarantool-patches [this message]
2024-12-06  7:55   ` [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash Sergey Kaplun via Tarantool-patches
2024-12-06 10:16     ` Sergey Bronnikov via Tarantool-patches
2024-12-11 12:24   ` Maxim Kokryashkin via Tarantool-patches
2024-12-06  7:06 ` [Tarantool-patches] [PATCH luajit 2/2] test: skip sysprof tests with LUAJIT_DISABLE_SYSPROF Sergey Bronnikov via Tarantool-patches
2024-12-06  8:08   ` Sergey Kaplun via Tarantool-patches
2024-12-06 10:31     ` Sergey Bronnikov via Tarantool-patches
2024-12-11 12:25   ` Maxim Kokryashkin via Tarantool-patches
2024-12-17 12:23 ` [Tarantool-patches] [PATCH luajit 0/2] Respect LUAJIT_DISABLE_SYSPROF in sysprof tests Sergey Kaplun via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f150753add9e09fd2285ccaa7c70e6a6dc949ab.1733468484.git.sergeyb@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=estetus@gmail.com \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 1/2] test: small fixes in gh-8594-sysprof-ffunc-crash' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox