From: Serge Petrenko via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: v.shpilevoy@tarantool.org, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v2 1/2] box: remove unused variable in process_register()
Date: Thu, 2 Sep 2021 16:21:33 +0300 [thread overview]
Message-ID: <7ea3a5970d1106a4d557e845f69c3cde2b6b6486.1630588778.git.sergepetrenko@tarantool.org> (raw)
In-Reply-To: <cover.1630588778.git.sergepetrenko@tarantool.org>
replica_version_id is unused in box_process_register,
so no point in filling it with anything coming from a remote instance.
Besides, version id isn't sent in register at all.
Follow-up #6034
---
src/box/box.cc | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/box/box.cc b/src/box/box.cc
index 0b12b1328..2c8113cbb 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -2616,9 +2616,7 @@ box_process_register(struct ev_io *io, struct xrow_header *header)
struct tt_uuid instance_uuid = uuid_nil;
struct vclock replica_vclock;
- uint32_t replica_version_id;
- xrow_decode_register_xc(header, &instance_uuid, &replica_vclock,
- &replica_version_id);
+ xrow_decode_register_xc(header, &instance_uuid, &replica_vclock, NULL);
if (!is_box_configured)
tnt_raise(ClientError, ER_LOADING);
--
2.30.1 (Apple Git-130)
next prev parent reply other threads:[~2021-09-02 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 13:21 [Tarantool-patches] [PATCH v2 0/2] replication: fix uninitialized replica_version_id access Serge Petrenko via Tarantool-patches
2021-09-02 13:21 ` Serge Petrenko via Tarantool-patches [this message]
2021-09-02 13:21 ` [Tarantool-patches] [PATCH v2 2/2] xrow: reset parameters of decode_subscribe() to default Serge Petrenko via Tarantool-patches
2021-09-02 21:47 ` Vladislav Shpilevoy via Tarantool-patches
2021-09-06 8:06 ` Serge Petrenko via Tarantool-patches
2021-09-07 21:46 ` Vladislav Shpilevoy via Tarantool-patches
2021-09-02 17:34 ` [Tarantool-patches] [PATCH v2 0/2] replication: fix uninitialized replica_version_id access Cyrill Gorcunov via Tarantool-patches
2021-09-09 10:18 ` Kirill Yukhin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea3a5970d1106a4d557e845f69c3cde2b6b6486.1630588778.git.sergepetrenko@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v2 1/2] box: remove unused variable in process_register()' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox