From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
To: tarantool-patches@freelists.org,
"n.pettik@corp.mail.ru" <n.pettik@corp.mail.ru>
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless legacy Cursor hints
Date: Tue, 19 Jun 2018 12:41:42 +0300 [thread overview]
Message-ID: <7e2820f7-694f-a4ee-4d99-905c57866928@tarantool.org> (raw)
In-Reply-To: <871fb50b-d725-f8b6-10b6-8c8513473a24@tarantool.org>
Nikita, please take a look.
On 13.06.2018 11:48, Vladislav Shpilevoy wrote:
> Hello. Thanks for the fixes!
>
> LGTM.
>
> On 13/06/2018 09:43, Kirill Shcherbatov wrote:
>>> 1. The same comment. What have you write after '---'?
>> Ok, I'll try to do not forget about it in next time. It were not obvious for me to edit ./create_commits.sh result files.
>
> ./create_commits.sh is not a standard util. It is just my helper for multi-commit
> patches. If you know how, you can implement Branch/Issue adding for single-commit
> patches, and I will share it.
>
>>
>> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3121-useless-hints
>> Issue: https://github.com/tarantool/tarantool/issues/3121
>>
>>> 2. I have pushed my fixes as a separate commit. Please,
>>> look, perceive and squash.
>> Done. Tnx.
>>
>
next prev parent reply other threads:[~2018-06-19 9:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-09 13:09 [tarantool-patches] " Kirill Shcherbatov
2018-06-09 21:41 ` [tarantool-patches] " Vladislav Shpilevoy
2018-06-13 6:43 ` [tarantool-patches] " Kirill Shcherbatov
2018-06-13 8:48 ` Vladislav Shpilevoy
2018-06-19 9:41 ` Kirill Shcherbatov [this message]
2018-06-19 14:03 ` n.pettik
2018-06-19 14:31 ` Kirill Shcherbatov
2018-06-19 18:31 ` n.pettik
2018-06-20 6:58 ` Kirill Shcherbatov
2018-06-20 9:05 ` n.pettik
2018-06-22 12:11 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e2820f7-694f-a4ee-4d99-905c57866928@tarantool.org \
--to=kshcherbatov@tarantool.org \
--cc=n.pettik@corp.mail.ru \
--cc=tarantool-patches@freelists.org \
--subject='[tarantool-patches] Re: [PATCH v1 1/1] sql: drop useless legacy Cursor hints' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox