From: Serge Petrenko <sergepetrenko@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/4] xrow: add ability to encode/decode ROLLBACK requests
Date: Fri, 19 Jun 2020 20:30:16 +0300 [thread overview]
Message-ID: <7e0d163b-b15e-5061-71ea-4a7171cf52e9@tarantool.org> (raw)
In-Reply-To: <20200618144653.GR134822@grain>
18.06.2020 17:46, Cyrill Gorcunov пишет:
>> diff --git a/src/box/xrow.c b/src/box/xrow.c
>> index 896e001b7..7a79a18dd 100644
>> --- a/src/box/xrow.c
>> +++ b/src/box/xrow.c
>> @@ -879,7 +879,8 @@ xrow_encode_dml(const struct request *request, struct region *region,
>> }
>>
>> int
>> -xrow_encode_confirm(struct xrow_header *row, uint32_t replica_id, int64_t lsn)
>> +xrow_encode_confirm_rollback(struct xrow_header *row, uint32_t replica_id,
>> + int64_t lsn)
>> {
> Should not it be a static function?
I agree, thanks for noticing!
Fixed.
--
Serge Petrenko
next prev parent reply other threads:[~2020-06-19 17:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 12:13 [Tarantool-patches] [PATCH 0/4] sync replication: add rollback processing Serge Petrenko
2020-06-18 12:14 ` [Tarantool-patches] [PATCH 1/4] xrow: fix comment typo Serge Petrenko
2020-06-18 22:15 ` Vladislav Shpilevoy
2020-06-18 22:15 ` Vladislav Shpilevoy
2020-06-19 17:28 ` Serge Petrenko
2020-06-18 12:14 ` [Tarantool-patches] [PATCH 2/4] xrow: add ability to encode/decode ROLLBACK requests Serge Petrenko
2020-06-18 14:46 ` Cyrill Gorcunov
2020-06-19 17:30 ` Serge Petrenko [this message]
2020-06-18 12:14 ` [Tarantool-patches] [PATCH 3/4] txn_limbo: add timeout when waiting for acks Serge Petrenko
2020-06-18 12:14 ` [Tarantool-patches] [PATCH 4/4] txn_limbo: add ROLLBACK processing Serge Petrenko
2020-06-18 22:15 ` Vladislav Shpilevoy
2020-06-19 17:35 ` Serge Petrenko
2020-06-21 15:53 ` Vladislav Shpilevoy
2020-06-19 17:53 ` Serge Petrenko
2020-06-23 8:37 ` Serge Petrenko
2020-06-25 22:14 ` Vladislav Shpilevoy
2020-06-25 22:43 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e0d163b-b15e-5061-71ea-4a7171cf52e9@tarantool.org \
--to=sergepetrenko@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/4] xrow: add ability to encode/decode ROLLBACK requests' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox