From: Aleksandr Lyapunov <alyapunov@tarantool.org>
To: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] Fix make_scoped_guard usage
Date: Wed, 8 Jul 2020 15:08:56 +0300 [thread overview]
Message-ID: <7dbb3c3f-4eb5-4b8d-9ec6-b0e425c6e650@tarantool.org> (raw)
In-Reply-To: <1594210027-332-1-git-send-email-alyapunov@tarantool.org>
+reviewers
On 08.07.2020 15:07, Aleksandr Lyapunov wrote:
> make_scoped_guard usually captures scope by [=].
> In some cases it could lead to unexpected results.
> I found several problems and fixed them.
>
> GH issue: https://github.com/tarantool/tarantool/issues/5154
> GH branch: https://github.com/tarantool/tarantool/tree/alyapunov/gh-5154-wrong-scoped-guards
>
> Aleksandr Lyapunov (1):
> Fix wrong make_scoped_guard usage
>
> src/box/alter.cc | 4 ++--
> src/main.cc | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
next prev parent reply other threads:[~2020-07-08 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 12:07 Aleksandr Lyapunov
2020-07-08 12:07 ` [Tarantool-patches] [PATCH] Fix wrong " Aleksandr Lyapunov
2020-07-08 12:15 ` Timur Safin
2020-07-08 12:16 ` Cyrill Gorcunov
2020-07-09 10:24 ` Nikita Pettik
2020-07-08 12:08 ` Aleksandr Lyapunov [this message]
2020-07-13 13:40 ` [Tarantool-patches] [PATCH] Fix " Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbb3c3f-4eb5-4b8d-9ec6-b0e425c6e650@tarantool.org \
--to=alyapunov@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] Fix make_scoped_guard usage' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox