From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Oleg Babin <olegrok@tarantool.org>,
tarantool-patches@dev.tarantool.org, imun@tarantool.org
Cc: Oleg Babin <babinoleg@mail.ru>
Subject: Re: [Tarantool-patches] [PATCH 0/3] lua: table fixes
Date: Sat, 15 Feb 2020 16:35:04 +0100 [thread overview]
Message-ID: <7d2d5e24-3f80-94d8-03b2-58dd2ecd3bf9@tarantool.org> (raw)
In-Reply-To: <78dc24fe-1b6e-b84d-3705-6f385e9db273@tarantool.org>
> I asked Igor M. about this patchset and he said
> that final decision has not yet been made and patch with __pairs/__ipairs metamethods could be reverted. Then two my patches will not be needed. Therefore I will wait final decision.
Ok. It was also decided, that debug.* usage to get a metatable
is not acceptable, so we will port deepcopy() to C.
>
> And I have a question about
>> Additionally, we have a new rule, that behaviour changing
>> tickets should be reflected in changelog. This ticket changes
>> behaviour. So you need to add a changelog label. Like this:
>
> Why I should get it from you but not from tarantool developers guide https://www.tarantool.io/en/doc/2.2/dev_guide/developer_guidelines/ ?
This is not a question for me.
prev parent reply other threads:[~2020-02-15 15:35 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 20:33 olegrok
2020-02-13 20:33 ` [Tarantool-patches] [PATCH 1/3] lua: fix incorrect table.deepcopy __metatable handling olegrok
2020-02-13 22:50 ` Vladislav Shpilevoy
2020-02-20 11:12 ` Igor Munkin
2020-02-13 20:33 ` [Tarantool-patches] [PATCH 2/3] lua: table.deepcopy ignores __pairs metamethod olegrok
2020-02-13 22:50 ` Vladislav Shpilevoy
2020-02-20 11:00 ` Igor Munkin
2020-02-13 20:33 ` [Tarantool-patches] [PATCH 3/3] tap: is_deeply " olegrok
2020-02-13 22:50 ` Vladislav Shpilevoy
2020-02-20 10:57 ` Igor Munkin
2020-02-13 22:50 ` [Tarantool-patches] [PATCH 0/3] lua: table fixes Vladislav Shpilevoy
2020-02-15 10:05 ` Oleg Babin
2020-02-15 15:35 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d2d5e24-3f80-94d8-03b2-58dd2ecd3bf9@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=babinoleg@mail.ru \
--cc=imun@tarantool.org \
--cc=olegrok@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/3] lua: table fixes' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox