From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: Maxim Kokryashkin <max.kokryashkin@gmail.com>,
tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream
Date: Thu, 9 Nov 2023 10:06:27 +0300 [thread overview]
Message-ID: <7cfd987c-2740-42bb-9f45-730e8bbc9352@tarantool.org> (raw)
In-Reply-To: <vtfkvxv25psu4wvsxqsqaiug7jjwexjwow3b5rpvemlwuwedgn@qw2s56pwivm4>
Hi, Max
On 11/9/23 02:01, Maxim Kokryashkin wrote:
> Hi!
> Thanks for the review!
> Fixed your comment, branch is force-pushed. Diff is below:
> ===
> diff --git a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
> index 347bd087..90a19156 100644
> --- a/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
> +++ b/test/tarantool-tests/gh-8594-sysprof-ffunc-crash.test.lua
> @@ -48,6 +48,6 @@ end
> res, err = misc.sysprof.stop()
> assert(res, err)
>
> -test:ok(true, 'sysprof finished successfully')
> +test:ok(true, 'FFUNC frames were streamed correctly')
>
> os.exit(test:check() and 0 or 1)
> ===
>
Thanks! LGTM as I said before
next prev parent reply other threads:[~2023-11-09 7:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 12:28 Maxim Kokryashkin via Tarantool-patches
2023-07-13 8:12 ` Sergey Bronnikov via Tarantool-patches
2023-07-14 14:30 ` Maxim Kokryashkin via Tarantool-patches
2023-11-08 15:47 ` Sergey Bronnikov via Tarantool-patches
2023-11-08 23:01 ` Maxim Kokryashkin via Tarantool-patches
2023-11-09 7:06 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-07-15 15:36 ` Sergey Kaplun via Tarantool-patches
2023-07-17 12:52 ` Maxim Kokryashkin via Tarantool-patches
2023-11-23 6:32 ` Igor Munkin via Tarantool-patches
-- strict thread matches above, loose matches on Subject: below --
2023-07-05 8:56 Maxim Kokryashkin via Tarantool-patches
2023-07-09 12:21 ` Sergey Kaplun via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cfd987c-2740-42bb-9f45-730e8bbc9352@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=max.kokryashkin@gmail.com \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v3] sysprof: fix crash during FFUNC stream' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox